-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-6588: Fixing additional merge review comments #99675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-6588: Fixing additional merge review comments #99675
Conversation
@Dhruv-Soni11: This pull request references RHDEVDOCS-6588 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri Sep 26 12:39:13 - Prow CI generated the docs preview: https://99675--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes-1-18.html |
6a27525
to
9332b2f
Compare
@Dhruv-Soni11: This pull request references RHDEVDOCS-6588 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-6588 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work, added just small nits:
9332b2f
to
b03e4c0
Compare
@Dhruv-Soni11: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick gitops-docs-1.18 |
@eromanova97: new pull request created: #99770 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
gitops-docs-1.18
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6588
Link to docs preview:
Release notes for Red Hat OpenShift GitOps 1.18.0
QE review:
Additional information:
This PR mainly contains merge review fixes to @eromanova97's comments in this PR.