-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS 12580 Enable Dynamic Resource Allocations for openshift #99730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Mon Oct 06 20:05:24 - Prow CI generated the docs preview: |
6254fdb
to
c0735e9
Compare
@tkashem Can you PTAL? |
_attributes/common-attributes.adoc
Outdated
// Formerly out-of-cluster layering | ||
:image-mode-os-out-caps: Out-of-cluster image mode | ||
:image-mode-os-out-lower: out-of-cluster image mode | ||
:attribute-based-full: Attribute-Based GPU Allocation in OpenShift with the NVIDIA GPU Operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably omit with the NVIDIA GPU Operator
, in 4.20 we are tech previewing Attribute-Based GPU Allocation only so vendors/partners can implement their DRA driver?
|
||
// Taken from https://issues.redhat.com/browse/OCPSTRAT-1756 | ||
{attribute-based-full} enables pods to request GPUs based on specific device attributes. This attribute-based resource allocation is achieved by the NVIDIA GPU Operator with a DRA driver, such as the NVIDIA Kubernetes DRA driver. This ensures that each pod receives the exact GPU specifications it requires. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't support Nvidia GPU allocation in 4.20, so we should not probably mention Nvidia or their GPUs
|
||
Device class:: | ||
A device class is a category of devices that pods can claimed and how to select specific device attributes in claims. Some device drivers contain their own device class, such as the gpu.nvidia.com. Alternatively, an administrator can create device classes. A device class contains a device selector, which is a link:https://cel.dev/[common expression language (CEL)] expression that must evaluate to true if a device satisfies the request. | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the following specs refer to Nvidia GPU, oh so this will be marked as tech preview doc only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tech preview notice is in the top file (the assembly file). (I made the name change, but haven't committed the changes yet.)
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@asahay19 PTAL |
/lgtm |
https://issues.redhat.com/browse/OSDOCS-16432
Link to docs preview:
QE review: