OCPBUGS-62517: UPSTREAM: <carry>: add rollingUpdate strategy #515

jianzhangbjz · 2025-10-11T07:44:07Z

Try to address OCPBUGS-62517, don't use the defaut

  replicas: 1
  strategy:
    rollingUpdate:
      maxSurge: 25%        
      maxUnavailable: 25%

Because maxUnavailable: 25% -> At minimum, the number of available Pods can be as low as replicas - maxUnavailable = 1 - 1 = 0. During the update process, there may be a brief period of unavailability (0 available Pods).

openshift-ci-robot · 2025-10-11T07:44:13Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-62517, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Try to address OCPBUGS-62517, don't use the defaut
 replicas: 1
 strategy:
   rollingUpdate:
     maxSurge: 25%        
     maxUnavailable: 25%
Because maxUnavailable: 25% -> At minimum, the number of available Pods can be as low as replicas - maxUnavailable = 1 - 1 = 0 . During the update process, there may be a brief period of unavailability (0 available Pods).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-10-11T07:44:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [jianzhangbjz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jianzhangbjz · 2025-10-11T07:45:04Z

/jira refresh

openshift-ci-robot · 2025-10-11T07:45:12Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-62517, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2025-10-11T07:47:52Z

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade openshift/origin#30296

openshift-ci · 2025-10-11T07:47:54Z

@jianzhangbjz: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

openshift-ci · 2025-10-11T07:50:33Z

@jianzhangbjz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f5d19430-a676-11f0-94c5-62699442e377-0

jianzhangbjz · 2025-10-11T07:59:37Z

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade openshift/origin#30296

openshift-ci · 2025-10-11T07:59:41Z

@jianzhangbjz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3c6b0ba0-a678-11f0-92c8-f67e221b5c36-0

openshift-ci-robot · 2025-10-11T08:01:59Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-62517, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

In response to this:

Try to address OCPBUGS-62517, don't use the defaut
 replicas: 1
 strategy:
   rollingUpdate:
     maxSurge: 25%        
     maxUnavailable: 25%
Because maxUnavailable: 25% -> At minimum, the number of available Pods can be as low as replicas - maxUnavailable = 1 - 1 = 0. During the update process, there may be a brief period of unavailability (0 available Pods).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2025-10-11T08:56:45Z

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade openshift/origin#30296

openshift-ci · 2025-10-11T08:56:47Z

@jianzhangbjz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/36fb29e0-a680-11f0-8911-ca5bd5d7dc54-0

jianzhangbjz · 2025-10-11T09:08:04Z

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade openshift/origin#30296

openshift-ci · 2025-10-11T09:08:07Z

@jianzhangbjz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cc51cbb0-a681-11f0-8f10-ca60385ac26e-0

jianzhangbjz · 2025-10-11T10:12:47Z

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade openshift/origin#30296

openshift-ci · 2025-10-11T10:12:50Z

@jianzhangbjz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6618ba0-a68a-11f0-8675-95f454ec3ba8-0

tmshort · 2025-10-11T22:02:15Z

/hold
This can't be done downstream in this manner;
This change is outside the openshift directory. With very few exceptions, downstream changes are restricted to the openshift directory. It's OK to make temporary PRs for testing purposes, but we can't merge this as-is.

It either needs to be done upstream, or as part of the openshift/helm values files.

jianzhangbjz · 2025-10-13T00:46:19Z

Hi @tmshort , thanks for the info. I will create an upstream PR for it.

jianzhangbjz · 2025-10-13T00:46:35Z

/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

openshift-ci · 2025-10-13T00:46:38Z

@jianzhangbjz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/12dc89b0-a7ce-11f0-8365-c966809d4b92-0

jianzhangbjz · 2025-10-13T01:13:16Z

/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

openshift-ci · 2025-10-13T01:13:18Z

@jianzhangbjz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cc833640-a7d1-11f0-8bef-ba826643459b-0

tmshort · 2025-10-13T02:38:58Z

Upstream merged. Closing this. The a PR with the upstream code will get created on Monday US time.

tmshort · 2025-10-13T02:39:08Z

/close

openshift-ci · 2025-10-13T02:39:17Z

@tmshort: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-10-13T02:39:19Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-62517. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Try to address OCPBUGS-62517, don't use the defaut
 replicas: 1
 strategy:
   rollingUpdate:
     maxSurge: 25%        
     maxUnavailable: 25%
Because maxUnavailable: 25% -> At minimum, the number of available Pods can be as low as replicas - maxUnavailable = 1 - 1 = 0. During the update process, there may be a brief period of unavailability (0 available Pods).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 11, 2025

openshift-ci bot requested review from dtfranz and rashmigottipati October 11, 2025 07:44

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2025

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 11, 2025

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 11, 2025

openshift-ci bot mentioned this pull request Oct 11, 2025

OTA-1637: ClusterOperators should not go Progressing only for a node reboot openshift/origin#30296

Open

jianzhangbjz force-pushed the bug-62517 branch from d1f364e to 2d560be Compare October 11, 2025 07:59

jianzhangbjz force-pushed the bug-62517 branch from 2d560be to 0dfcecf Compare October 11, 2025 08:33

UPSTREAM: <carry>: add rollingUpdate strategy

adc84cf

jianzhangbjz force-pushed the bug-62517 branch from 0dfcecf to adc84cf Compare October 11, 2025 09:07

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2025

jianzhangbjz mentioned this pull request Oct 13, 2025

🐛 add rollingUpdate strategy operator-framework/operator-controller#2263

Merged

4 tasks

openshift-ci bot closed this Oct 13, 2025

OCPBUGS-62517: UPSTREAM: <carry>: add rollingUpdate strategy #515

OCPBUGS-62517: UPSTREAM: <carry>: add rollingUpdate strategy #515

Uh oh!

Conversation

jianzhangbjz commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 11, 2025

Uh oh!

openshift-ci bot commented Oct 11, 2025

Uh oh!

jianzhangbjz commented Oct 11, 2025

Uh oh!

openshift-ci-robot commented Oct 11, 2025

Uh oh!

jianzhangbjz commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 11, 2025

Uh oh!

openshift-ci bot commented Oct 11, 2025

Uh oh!

jianzhangbjz commented Oct 11, 2025

Uh oh!

openshift-ci bot commented Oct 11, 2025

Uh oh!

openshift-ci-robot commented Oct 11, 2025

Uh oh!

jianzhangbjz commented Oct 11, 2025

Uh oh!

openshift-ci bot commented Oct 11, 2025

Uh oh!

jianzhangbjz commented Oct 11, 2025

Uh oh!

openshift-ci bot commented Oct 11, 2025

Uh oh!

jianzhangbjz commented Oct 11, 2025

Uh oh!

openshift-ci bot commented Oct 11, 2025

Uh oh!

tmshort commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jianzhangbjz commented Oct 13, 2025

Uh oh!

jianzhangbjz commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

jianzhangbjz commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

tmshort commented Oct 13, 2025

Uh oh!

tmshort commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

openshift-ci-robot commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jianzhangbjz commented Oct 11, 2025 •

edited

Loading

jianzhangbjz commented Oct 11, 2025 •

edited

Loading

tmshort commented Oct 11, 2025 •

edited

Loading