Skip to content

Conversation

jianzhangbjz
Copy link
Contributor

Description

To address the issue: the cluster operator olm Available=False when cluster upgrading.
I have tested this solution in openshift/operator-framework-operator-controller#515, and it works.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@jianzhangbjz jianzhangbjz requested a review from a team as a code owner October 13, 2025 01:14
Copy link

netlify bot commented Oct 13, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 9e5978e
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68ec6010f194da0008fbe026
😎 Deploy Preview https://deploy-preview-2263--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from bentito and perdasilva October 13, 2025 01:14
@jianzhangbjz
Copy link
Contributor Author

jianzhangbjz commented Oct 13, 2025

https://github.com/operator-framework/operator-controller/actions/runs/18452353047/job/52567797659?pr=2263 failed at:

    cluster_extension_install_test.go:1052: By eventually reporting Progressing == True with Reason Retrying
    cluster_extension_install_test.go:1053: 
        	Error Trace:	/home/runner/work/operator-controller/operator-controller/test/e2e/cluster_extension_install_test.go:1058
        	            				/opt/hostedtoolcache/go/1.24.4/x64/src/runtime/asm_amd64.s:1700
        	Error:      	Not equal: 
        	            	expected: "Retrying"
        	            	actual  : "RolloutInProgress"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-Retrying
        	            	+RolloutInProgress
    cluster_extension_install_test.go:1053: 
        	Error Trace:	/home/runner/work/operator-controller/operator-controller/test/e2e/cluster_extension_install_test.go:1053
        	Error:      	Condition never satisfied
        	Test:       	TestClusterExtensionRecoversFromExistingDeploymentWhenFailureFixed

Signed-off-by: Jian Zhang <jiazha@redhat.com>
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.87%. Comparing base (95c5934) to head (9e5978e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2263   +/-   ##
=======================================
  Coverage   72.87%   72.87%           
=======================================
  Files          88       88           
  Lines        8733     8733           
=======================================
  Hits         6364     6364           
  Misses       1955     1955           
  Partials      414      414           
Flag Coverage Δ
e2e 39.29% <ø> (+0.03%) ⬆️
experimental-e2e 46.31% <ø> (ø)
unit 57.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor

tmshort commented Oct 13, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
Copy link

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@tmshort
Copy link
Contributor

tmshort commented Oct 13, 2025

https://github.com/operator-framework/operator-controller/actions/runs/18452353047/job/52567797659?pr=2263 failed at...
@jianzhangbjz this is an uncommon flake... to the point we usually just run the test again and it passes.

@openshift-merge-bot openshift-merge-bot bot merged commit 687401c into operator-framework:main Oct 13, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants