-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.7] setup selinux labels for build containers #17546
[release-3.7] setup selinux labels for build containers #17546
Conversation
@openshift/sig-developer-experience fyi / ptal |
i thought we agreed not to do this. but ok. /lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test crio |
ok, crio's failing because this is 3.7 and we are testing with a 3.8 CRI-O (v1.8.2) system container 😕 @mrunalp @stevekuznetsov we need a way to tell the CI that this should pull "docker.io/runcom/cri-o:v1.0.7" based on the fact this PR is against release-1.7 branch |
The branch is available to you in the job -- write code to pull the right CRI-O |
Awesome, ill do that thanks Steve |
/test crio |
1 similar comment
/test crio |
mmm crio job not kicking....does anyone know why? @mrunalp @stevekuznetsov @ashcrow |
/test crio |
The job is running, it is set to not report as it's running by default on all PRs like y'all asked for more signal. Look at your PR Overview to see the |
/retest |
/retest |
/test crio |
… is partial Signed-off-by: Antonio Murdaca <runcom@redhat.com>
727f0af
to
f6c0345
Compare
@bparees @stevekuznetsov @smarterclayton can we get this in? we support cri-o in 3.7 and we need this backport for Prow as well https://deck-ci.svc.ci.openshift.org/?job=test_pull_request_origin_extended_conformance_crio (failing jobs are mainly 3.7) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, derekwaynecarr, runcom The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test end_to_end |
/retest |
2 similar comments
/retest |
/retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
🤞 |
@runcom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
I jinxed it 😭 |
Automatic merge from submit-queue. |
back ports #17094 to
release-3.7
@smarterclayton PTAL