Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.7] setup selinux labels for build containers #17546

Merged
merged 2 commits into from
Feb 15, 2018

Conversation

runcom
Copy link
Member

@runcom runcom commented Nov 30, 2017

back ports #17094 to release-3.7

@smarterclayton PTAL

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2017
@gabemontero
Copy link
Contributor

@openshift/sig-developer-experience fyi / ptal

@bparees
Copy link
Contributor

bparees commented Nov 30, 2017

i thought we agreed not to do this. but ok.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 30, 2017
@runcom runcom closed this Nov 30, 2017
@runcom runcom reopened this Nov 30, 2017
@gabemontero gabemontero removed their request for review November 30, 2017 23:12
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2017
@openshift-merge-robot openshift-merge-robot added vendor-update Touching vendor dir or related files and removed lgtm Indicates that a PR is ready to be merged. labels Dec 1, 2017
@runcom
Copy link
Member Author

runcom commented Dec 1, 2017

/test crio

@runcom
Copy link
Member Author

runcom commented Dec 1, 2017

ok, crio's failing because this is 3.7 and we are testing with a 3.8 CRI-O (v1.8.2) system container 😕 @mrunalp @stevekuznetsov we need a way to tell the CI that this should pull "docker.io/runcom/cri-o:v1.0.7" based on the fact this PR is against release-1.7 branch

@stevekuznetsov
Copy link
Contributor

The branch is available to you in the job -- write code to pull the right CRI-O

@runcom
Copy link
Member Author

runcom commented Dec 1, 2017

The branch is available to you in the job -- write code to pull the right CRI-O

Awesome, ill do that thanks Steve

@runcom
Copy link
Member Author

runcom commented Dec 13, 2017

/test crio

1 similar comment
@runcom
Copy link
Member Author

runcom commented Dec 13, 2017

/test crio

@runcom
Copy link
Member Author

runcom commented Dec 13, 2017

mmm crio job not kicking....does anyone know why? @mrunalp @stevekuznetsov @ashcrow

@runcom
Copy link
Member Author

runcom commented Dec 13, 2017

/test crio

@stevekuznetsov
Copy link
Contributor

The job is running, it is set to not report as it's running by default on all PRs like y'all asked for more signal. Look at your PR Overview to see the cri-o test runs.

@runcom
Copy link
Member Author

runcom commented Dec 14, 2017

/retest

@bparees bparees removed their assignment Jan 4, 2018
@runcom
Copy link
Member Author

runcom commented Feb 13, 2018

/retest

@runcom
Copy link
Member Author

runcom commented Feb 13, 2018

/test crio

@runcom
Copy link
Member Author

runcom commented Feb 13, 2018

@bparees @stevekuznetsov @smarterclayton can we get this in? we support cri-o in 3.7 and we need this backport for Prow as well https://deck-ci.svc.ci.openshift.org/?job=test_pull_request_origin_extended_conformance_crio (failing jobs are mainly 3.7)

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, derekwaynecarr, runcom

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@runcom
Copy link
Member Author

runcom commented Feb 13, 2018

/test end_to_end

@ashcrow
Copy link
Member

ashcrow commented Feb 14, 2018

/retest

2 similar comments
@runcom
Copy link
Member Author

runcom commented Feb 14, 2018

/retest

@runcom
Copy link
Member Author

runcom commented Feb 15, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@ashcrow
Copy link
Member

ashcrow commented Feb 15, 2018

🤞

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 15, 2018

@runcom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_crio 727f0af link /test crio
ci/openshift-jenkins/extended_conformance_gce 727f0af link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom
Copy link
Member Author

runcom commented Feb 15, 2018

/retest

@ashcrow
Copy link
Member

ashcrow commented Feb 15, 2018

I jinxed it 😭

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit a8deba5 into openshift:release-3.7 Feb 15, 2018
@runcom runcom deleted the backport-17094 branch February 15, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants