Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShift Pipelines: remove nop image #5748

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

sthaha
Copy link
Contributor

@sthaha sthaha commented Nov 4, 2019

nop image is replaced by tianon/true
see: tektoncd/pipeline#1510

Signed-off-by: Sunil Thaha sthaha@redhat.com

`nop` image is replaced by `tianon/true`
see: tektoncd/pipeline#1510

Signed-off-by: Sunil Thaha <sthaha@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@openshift-ci-robot
Copy link
Contributor

@sthaha: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/tektoncd-pipeline/release-next/variant-images 9fd4f27 link /test pj-rehearse
ci/rehearse/openshift/tektoncd-pipeline/release-next/images 9fd4f27 link /test pj-rehearse
ci/prow/pj-rehearse 9fd4f27 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nikhil-thomas
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2ae050e into openshift:master Nov 4, 2019
@openshift-ci-robot
Copy link
Contributor

@sthaha: Updated the following 3 configmaps:

  • ci-operator-misc-configs configmap in namespace ci using the following files:
    • key openshift-tektoncd-pipeline-release-next.yaml using file ci-operator/config/openshift/tektoncd-pipeline/openshift-tektoncd-pipeline-release-next.yaml
    • key openshift-tektoncd-pipeline-release-next__variant.yaml using file ci-operator/config/openshift/tektoncd-pipeline/openshift-tektoncd-pipeline-release-next__variant.yaml
  • ci-operator-misc-configs configmap in namespace ci-stg using the following files:
    • key openshift-tektoncd-pipeline-release-next.yaml using file ci-operator/config/openshift/tektoncd-pipeline/openshift-tektoncd-pipeline-release-next.yaml
    • key openshift-tektoncd-pipeline-release-next__variant.yaml using file ci-operator/config/openshift/tektoncd-pipeline/openshift-tektoncd-pipeline-release-next__variant.yaml
  • image-mirror-mappings configmap in namespace ci using the following files:
    • key mapping_tekton_nihghtly_quay using file core-services/image-mirroring/tekton/mapping_tekton_nihghtly_quay

In response to this:

nop image is replaced by tianon/true
see: tektoncd/pipeline#1510

Signed-off-by: Sunil Thaha sthaha@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants