iD wipes "source:date" tag when "downgrading" an address node with store metadata #8097
Assignees
Milestone
Comments
quincylvania
added
operation
|
Hi and welcome, @joepie91. Thanks for bringing up this issue, I've fixed it for today's patch release. |
|
Excellent, thanks! |
Bonkles
referenced
this issue
in facebook/Rapid
Feb 2, 2021
* Don't instantiate uiShortcuts or its keybinding multiple times * Add another exception and only warn on typos * Don't translate US words to British Undo an errant edit * Skip deprecated because it will be full of typos by definition * Skip more typos we've deliberately left in * Ignore more deliberate typos, preemptively skip some others * Skip even more words that aren't actually typos * Add Tram & Bus Stop preset (close #7970) * Add terms for #7970 * Add `ramp` field to Steps preset (close #7977) * Fix a new typo which snuck in * Add another variant of a term given an earlier typo * Skip the deliberate typo * Followup to #8013 * Update to marked 1.2.0 (close #8029) * Initial support for D3 v6.2.0 * Bump rollup-plugin-visualizer from 4.0.4 to 4.1.1 Bumps [rollup-plugin-visualizer](https://github.com/btd/rollup-plugin-visualizer) from 4.0.4 to 4.1.1. - [Release notes](https://github.com/btd/rollup-plugin-visualizer/releases) - [Changelog](https://github.com/btd/rollup-plugin-visualizer/blob/master/CHANGELOG.md) - [Commits](https://github.com/btd/rollup-plugin-visualizer/commits) Signed-off-by: dependabot[bot] <support@github.com> * Update fontawesome (close #8060) * Update various preset icons (re: #7068) * Add terms to hardware and DIY store presets * Update more code for D3 v6 * Delete ROADMAP.md Move roadmap to https://github.com/openstreetmap/iD/wiki/Development-Roadmap * Use white for custom data label color (close #8055) * Bump mapillary-js from 2.20.0 to 2.21.0 Bumps [mapillary-js](https://github.com/mapillary/mapillary-js) from 2.20.0 to 2.21.0. - [Release notes](https://github.com/mapillary/mapillary-js/releases) - [Commits](mapillary/mapillary-js@v2.20.0...v2.21.0) Signed-off-by: dependabot[bot] <support@github.com> * Bump postcss from 7.0.35 to 8.1.1 Bumps [postcss](https://github.com/postcss/postcss) from 7.0.35 to 8.1.1. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/master/CHANGELOG.md) - [Commits](postcss/postcss@7.0.35...8.1.1) Signed-off-by: dependabot[bot] <support@github.com> * Use the layer names instead of the IDs in the imagery_used tag (close #7842) * Switch from buble to babel for ES5 transpilation (close #8065) * List some defaults explicitly * Support IE11 explicitly * Add some polyfills needed by D3 * Fix and simplify hover test * Bump autoprefixer from 9.8.6 to 10.0.1 Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 9.8.6 to 10.0.1. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md) - [Commits](postcss/autoprefixer@9.8.6...10.0.1) Signed-off-by: dependabot[bot] <support@github.com> * Bump @ideditor/location-conflation from 0.3.0 to 0.5.0 Bumps [@ideditor/location-conflation](https://github.com/ideditor/location-conflation) from 0.3.0 to 0.5.0. - [Release notes](https://github.com/ideditor/location-conflation/releases) - [Changelog](https://github.com/ideditor/location-conflation/blob/main/CHANGELOG.md) - [Commits](rapideditor/location-conflation@v0.3.0...v0.5.0) Signed-off-by: dependabot[bot] <support@github.com> * Bump @rollup/plugin-node-resolve from 8.1.0 to 9.0.0 Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins) from 8.1.0 to 9.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Commits](rollup/plugins@node-resolve-v8.1.0...node-resolve-v9.0.0) Signed-off-by: dependabot[bot] <support@github.com> * Followup to #8067 * Run build:stats * Divide up the `step_count` tag value proportionally when splitting ways (close #8069) * Fix potential JavaScript error * Add Cooling Tower preset * Bump rollup from 2.23.1 to 2.29.0 Bumps [rollup](https://github.com/rollup/rollup) from 2.23.1 to 2.29.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.23.1...v2.29.0) Signed-off-by: dependabot[bot] <support@github.com> * Bump uglify-js from 3.10.4 to 3.11.2 Bumps [uglify-js](https://github.com/mishoo/UglifyJS) from 3.10.4 to 3.11.2. - [Release notes](https://github.com/mishoo/UglifyJS/releases) - [Commits](mishoo/UglifyJS@v3.10.4...v3.11.2) Signed-off-by: dependabot[bot] <support@github.com> * Make connection status links keyboard-navigable (re: #8004) * Update date field styling * Persist photo layer filters in the URL * Don't suggest tidal=yes on waterway=tidal_channel (close #8072) * Add `increment` property for numeric fields (close #7867) * Add extra note focus safety check * Switch to core-js for polyfills * Send keydown events when testing uiCombobox * Remove unneeded imports * npm run build:stats * Bump rollup from 2.29.0 to 2.30.0 Bumps [rollup](https://github.com/rollup/rollup) from 2.29.0 to 2.30.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.29.0...v2.30.0) Signed-off-by: dependabot[bot] <support@github.com> * Remove some unneeded variables. These should theoretically actually slow down the JIT (if very marginally) so performance-wise it's better not to have them. * Make a variable inline * Remove some more unused variable assignments * Add back (and fix) an assignment. * Support the Relations editor for multiple selected features (close #7753) * Fix unexpected tag removal on upgrade (close #8089) * Fix change event for d3 6 * Don't show username filter for streetside * Read photo filters from hash before reading enabled overlays/photos * Validate filter date values from hash/input Compensate if from date is set after to date * Use HTML translated string endpoints for photo option labels * Use localized placeholder for expected date filter format * Reload date filter values after input change * Bump rollup from 2.30.0 to 2.31.0 Bumps [rollup](https://github.com/rollup/rollup) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.30.0...v2.31.0) Signed-off-by: dependabot[bot] <support@github.com> * Add name field to park and ride preset * Add `usage` field property to provide more info on how a field is used * Add warning about unused fields to build_data script * Add fields to Outdoor Seating Area preset, including Heating * Apply further suggestions from code review. * Undo unnecessary formatting change. * Bump rollup from 2.31.0 to 2.32.0 Bumps [rollup](https://github.com/rollup/rollup) from 2.31.0 to 2.32.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.31.0...v2.32.0) Signed-off-by: dependabot[bot] <support@github.com> * Bump @ideditor/country-coder from 3.2.0 to 4.0.0 Bumps [@ideditor/country-coder](https://github.com/ideditor/country-coder) from 3.2.0 to 4.0.0. - [Release notes](https://github.com/ideditor/country-coder/releases) - [Commits](rapideditor/country-coder@v3.2.0...v4.0.0) Signed-off-by: dependabot[bot] <support@github.com> * Add man_made=windpump preset (close #7709) * Support territories in preset and field country limiters (re: #8102) * Combine `fromDate` and `toDate` parameters into single `photo_dates` parameter Rename `username` parameter to `photo_username` Add API documentation of photo filter parameters * Disable auto features on photo filter inputs * Don't allow date separators that could be used in some date formats * Support filtering by multiple photo usernames * Make sure photo filter controls are always shown in the same order * Adjust photo filter input styling * Add reminder about iD's URL parameters to releasing doc * Remove unused `direction_cardinal` field (close #8096) * Add the initial 2.19.0 changelog * Add missing link * Update to temaki 4.3.0 * Update changelog * Followup to #8083 * Update changelog * Use bold text for touchscreen edit menu again * Don't warn about deprecated tags that would overwrite existing data when upgraded (close #7843) * Update changelog * Revert "Support territories in preset and field country limiters (re: #8102)" This reverts commit a3a9259. * Revert "Bump @ideditor/country-coder from 3.2.0 to 4.0.0" This reverts commit cfd1340. * Update osm-community-index to 2.1.2 * Update missed d3 v6 endpoints (re: #8056) * Reset validator whenever reseting the history (close #8108) * en.json modified * Added the missing units for water tank * Bump marked from 1.2.0 to 1.2.2 Bumps [marked](https://github.com/markedjs/marked) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v1.2.0...v1.2.2) Signed-off-by: dependabot[bot] <support@github.com> * Fix styling of instructions in the walkthrough * Update changelog * Enable additional eslint rules, including no-unreachable-loop * Enable additional eslint rules, including no-constructor-return * Enable additional eslint rules, including no-useless-concat * Enable no-eq-null eslint rule * Enable no-undef-init eslint rule * Add and sort eslint rules * Enable complexity eslint rule and simplify uiPresetIcon.render function * Enable no-duplicate-imports eslint rule * Enable arrow-spacing eslint rule * Enable some eslint rules than are already in compliance * Add lint:fix script Enable no-trailing-space eslint rule * Enable some eslint rules than are already in compliance * Enable block-scoped-var eslint rule * Enable array-callback-return eslint rule * Enable no-implicit-coercion eslint rule for strings * Fix tests * Fix background tile issues caused by the cache not properly updating upon load/error with D3 v6 * Fix issue with context menu key * Fix issue with snapping to ways/nodes when drawing * Bump @rollup/plugin-node-resolve from 9.0.0 to 10.0.0 Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins) from 9.0.0 to 10.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Commits](rollup/plugins@node-resolve-v9.0.0...node-resolve-v10.0.0) Signed-off-by: dependabot[bot] <support@github.com> * Fix issue where clicking some buttons would clear the URL hash * Clean up the imagery offset layout and make it usable via keyboard only * Update changelog * Fix issue with mobile Safari showing the native selection menu when long-pressing on the map * Add 2.19.0 release highlights to changelog * npm run imagery * npm run translations * v2.19.0 * Set development version number * Fix changelog typo * Fix alignment issues with new version badge * Fix critical issue with editing Bike Lanes and Allowed Access fields * Fix issue with expanding the sidebar after drawing a generic feature * Fix lint warnings and error * npm run translations * v2.19.1 * Update CHANGELOG.md * Set development version number * Update line.js fix walkthrough hangs when "Washington street" is split * npm run translations * npm run imagery * v2.19.2 * Set development version number * Fix issue where switching between metric/imperial measurements wouldn't work * Fix regression where hovering over items in the relation dropdown wouldn't highlight them in the map (close #8134) * Fix regression where changing the Wikidata field wouldn't update the `wikidata` tag (close #8132) * Update ui.checkOverflow to only apply to iD's subelements and to account for empty selections * Fix issue where sidebar controls could be keyboard-navigated while the sidebar was hidden * Improve styling of new version badge * Apply photo date and username filters to Mapillary sign and object detections (close #8133) Don't update disabled SVG layers upon photo changes * Avoid error if detection images haven't been loaded yet * Improve tab order of attribution links and zoom in to edit notice * Make the warnings and errors lists in the issues pane navigable via keyboard * Add hover/focus/active styling for oneway reverser button * Don't remove `source:*` tags when downgrading features (close #8097) * Account for instances where d3.geoCentroid returns incorrect results * npm run translations * v2.19.3 * Set development version number * Bump @rollup/plugin-commonjs from 15.1.0 to 16.0.0 Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins) from 15.1.0 to 16.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Commits](rollup/plugins@commonjs-v15.1.0...commonjs-v16.0.0) Signed-off-by: dependabot[bot] <support@github.com> * fix error when custom background url is empty * Change implementation of #8141 * Update data_layers.js to be consistent with 2a2bfca * Fix issue where the keyboard shortcuts screen would only display the first tab (close #8137) * Add missing links * Update my username in the changelog file * Bump rollup from 2.32.1 to 2.33.0 Bumps [rollup](https://github.com/rollup/rollup) from 2.32.1 to 2.33.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.32.1...v2.33.0) Signed-off-by: dependabot[bot] <support@github.com> * Update to cldr 37 * Add phone field to warehouse preset (close #8150) * Fix issue where items could not be deselected from the selection list in some browsers (close #8151) * npm run translations * npm run imagery * v2.19.4 * Set development version number * Use volume capacity field for covered reservoirs (re: #8112) * Bump rollup-plugin-visualizer from 4.1.2 to 4.2.0 Bumps [rollup-plugin-visualizer](https://github.com/btd/rollup-plugin-visualizer) from 4.1.2 to 4.2.0. - [Release notes](https://github.com/btd/rollup-plugin-visualizer/releases) - [Changelog](https://github.com/btd/rollup-plugin-visualizer/blob/master/CHANGELOG.md) - [Commits](https://github.com/btd/rollup-plugin-visualizer/commits/v4.2.0) Signed-off-by: dependabot[bot] <support@github.com> * Update marked and don't worry about patches going forward (close #8166) * Download, select, and display the feature specified in the URL upon load even if the map parameter is zoomed out beyond the editable extent (close #8122) * Fix issue where existing multiCombo field values wouldn't appear (close #8155) * Use the actual dropdown label for the localized name language input label (re: #8165) * Show multilingual values in the Name field even for keys with spaces or other unexpected characters (re: #8165) * Write the languages.json file in build_data.js instead of update_locales.js (re: #8165) * Include languages in the Multilingual Name field dropdown even if they don't have native labels in CLDR Don't bundle translated names for languages that won't be shown in the multilingual name field * npm run translations * Fix issue with dragging node in between editing its tags (close #7606) * npm run imagery * npm run imagery * v2.19.5 * Check in build * One bugfix and one test modification to accomodate a new mapillary layer. * Add more styling and a slight delay before we show RapiD feature information in the sidebar. This prevents flickering as the user scans the mouse over many features very quickly, only showing the information when the mouse comes to rest on top of one. * Further plumbing fixes to onclick() methods that don't receive nodes[] anymore, which fixes a bunch of typeErrors. * Fix a bug that caused the 'Log into OSM / No thanks' button options to be extremely tall. * Fix color picker and rapid toggle buttons. These broke in the d3-v6 transition. * Fix bug that was preventing the introduction (walkthrough) from starting on first click. * Update changelog, bump rapid version. * Update changelog, bump rapid version. * Fix issue that prevented the 'AI features limit' flash text from appearing. * Fix a couple of warnings, also fix 'next/prev' background imagery hotkey functionality. * Fix console log error during y-shaped connection issue. Also fix background imagery selection via mouse (keyboard worked fine) * Fix issue that was preventing color changes from taking place. Co-authored-by: Quincy Morgan <2046746+quincylvania@users.noreply.github.com> Co-authored-by: Peter Newman <peternewman@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nikola Plesa <nickplesha@gmail.com> Co-authored-by: teymour-aldridge <teymour.aldridge@icloud.com> Co-authored-by: Evan Siroky <evan.siroky@yahoo.com> Co-authored-by: Karmanya Veer Sharma <karmanyasharma5@gmail.com> Co-authored-by: ricloy <ricloy@users.noreply.github.com> Co-authored-by: Wille Marcel <wille.yyz@gmail.com> Co-authored-by: Kyle Mckay <5459452+kymckay@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example case: https://www.openstreetmap.org/changeset/92596968
When applying the 'downgrade' action to an address node that also includes other (eg. store) information, it leaves the
sourcetag intact but removes thesource:datetag, which is apparently necessary for those working with BAG (Dutch government) datasets to determine the age of certain information.I'm guessing that the reason is that iD has
sourcein its tag exclude list for downgrading, but notsource:*. Also keeping any subtags ofsourceintact upon downgrading (ie. treating them as address data) seems like a reasonable solution to me, though I realize I haven't worked with OSM much and so there may be issues with that that I'm not aware of.Edit: Sorry, forgot the platform information. Firefox 81.0 (64-bit), NixOS 20.03 (Linux).
The text was updated successfully, but these errors were encountered: