fix(sdk): deserialize object statement values correctly #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkleene
changed the title
mkleene
changed the title
|
elizabethhealy
approved these changes
Jan 28, 2025
mkleene
added a commit
to opentdf/tests
that referenced
this pull request
Jan 29, 2025
…245) Filewatcher sets assertion values as JSON objects like ``` "statement": { "format": "string", "value": { "context": { "@base": "urn:nato:stanag:5636:A:1:elements:json" }, "ocl": { "catl": [ { "name": "Releasable To", "type": "P", "vals": [ "usa" ] } ], "pol": "2ccf11cb-6c9a-4e49-9746-a7f0a295945d", "cls": "SECRET", "dcr": "2024-12-17T13:00:52Z" } } ``` this adds a test that makes sure that all SDKs can properly deserialize such manifests when they have assertion verification disabled. In order to make this work we needed to pass through an option that disables assertion verification. Requires opentdf/platform#1833 and opentdf/java-sdk#219 to be merged before it will pass successful run against SDK branches: https://github.com/opentdf/tests/actions/runs/12992325319/job/36231902231
mkleene
pushed a commit
that referenced
this pull request
Feb 6, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>0.7.6</summary> ## [0.7.6](v0.7.5...v0.7.6) (2025-02-06) ### Features * Add assertion verification ([#216](#216)) ([e0f8caf](e0f8caf)) * **cmdline:** assertions cli support ([#204](#204)) ([3325114](3325114)) * **sdk:** Add and expose tamper error types ([#187](#187)) ([b4f95e6](b4f95e6)) * **sdk:** adds Collections API ([#212](#212)) ([1ee1367](1ee1367)) ### Bug Fixes * Correct null assertions when deserializing ([#211](#211)) ([b075194](b075194)) * incorrect isStreamable serialized name ([#210](#210)) ([32825b0](32825b0)) * NanoTDF secure key from debug logging and iv conflict risk ([#208](#208)) ([6301d32](6301d32)) * **sdk:** deserialize object statement values correctly ([#219](#219)) ([c513e8c](c513e8c)) * **sdk:** Fuzz testing and protocol fixes ([#214](#214)) ([cf6f932](cf6f932)) * **sdk:** group splits with empty/missing split IDs together ([#217](#217)) ([0f47702](0f47702)) * **sdk:** remove hex encoding ([#213](#213)) ([e076d11](e076d11)) * **sdk:** uses offset for ByteBuffer array offset ([#209](#209)) ([0d6e761](0d6e761)) * Use reusable start-additional-kas workflow ([#215](#215)) ([cb6f757](cb6f757)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SDKs don't set assertion values as objects instead of strings so we set them to string values when we deserialize
Also:
gsoninstance that we use forManifestdeserialization so that we don't have tokeep setting the options in different places
ManifestDeserializersince its purpose is to make theassertionslist non-null but sincewe have encapsulated the deserialization we can set it there
cmdlineapp so that we can do so in xtests