-
Notifications
You must be signed in to change notification settings - Fork 2
feat(sdk)!: DSPX-1037 update sdk api #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SPX-1037-update-sdk-api
|
dmihalcik-virtru
approved these changes
May 7, 2025
Member
dmihalcik-virtru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better; are there any other changes we want to make before stamping a 1.0 API?
mkleene
pushed a commit
that referenced
this pull request
May 27, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>0.8.0</summary> ## [0.8.0](v0.7.9...v0.8.0) (2025-05-27) ### ⚠ BREAKING CHANGES * **sdk:** better control which classes we expose ([#254](#254)) * **sdk:** expose method to build an http client ([#256](#256)) * **sdk:** switch to `connect-rpc` for GRPC ([#244](#244)) * **sdk:** DSPX-1037 update sdk api ([#249](#249)) ### Features * Add initial Dependency Review configuration ([#252](#252)) ([ba11d49](ba11d49)) * **sdk:** add nanotdf plaintext policy ([#259](#259)) ([be9cd94](be9cd94)) * **sdk:** better control which classes we expose ([#254](#254)) ([e00eeaf](e00eeaf)) * **sdk:** DSPX-1037 update sdk api ([#249](#249)) ([f2e1307](f2e1307)) * **sdk:** expose method to build an http client ([#256](#256)) ([2cac97c](2cac97c)) * **sdk:** switch to `connect-rpc` for GRPC ([#244](#244)) ([ff36a1d](ff36a1d)) ### Bug Fixes * **sdk:** add coverage ([#258](#258)) ([e6ad1bc](e6ad1bc)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


We were making clients instantiate a
TDFobject which exposed methods likeloadTDFthat took in the particular services it needed to perform an operation. So we refactor
TDFto take inall possible services it could need in its constructor
and hide calls to
new TDFinside methods on SDK. So now loading a TDF looks like this