Skip to content

Conversation

@mkleene
Copy link
Contributor

@mkleene mkleene commented May 2, 2025

We were making clients instantiate a TDF object which exposed methods like loadTDF
that took in the particular services it needed to perform an operation. So we refactor TDF to take in
all possible services it could need in its constructor

new TDF(services).loadTDF(...);

and hide calls to new TDF inside methods on SDK. So now loading a TDF looks like this

sdk.createTDF(in, out, tdfConfig);

@mkleene mkleene changed the title Dspx 1037 update sdk api feat: DSPX-1037 update sdk api May 5, 2025
@mkleene mkleene marked this pull request as ready for review May 5, 2025 13:54
@mkleene mkleene requested review from a team as code owners May 5, 2025 13:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mkleene mkleene changed the title feat: DSPX-1037 update sdk api feat!: DSPX-1037 update sdk api May 7, 2025
@mkleene mkleene changed the title feat!: DSPX-1037 update sdk api feat(sdk)!: DSPX-1037 update sdk api May 7, 2025
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better; are there any other changes we want to make before stamping a 1.0 API?

@mkleene mkleene merged commit f2e1307 into main May 8, 2025
10 of 11 checks passed
@mkleene mkleene deleted the DSPX-1037-update-sdk-api branch May 8, 2025 16:15
mkleene pushed a commit that referenced this pull request May 27, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>0.8.0</summary>

## [0.8.0](v0.7.9...v0.8.0)
(2025-05-27)


### ⚠ BREAKING CHANGES

* **sdk:** better control which classes we expose
([#254](#254))
* **sdk:** expose method to build an http client
([#256](#256))
* **sdk:** switch to `connect-rpc` for GRPC
([#244](#244))
* **sdk:** DSPX-1037 update sdk api
([#249](#249))

### Features

* Add initial Dependency Review configuration
([#252](#252))
([ba11d49](ba11d49))
* **sdk:** add nanotdf plaintext policy
([#259](#259))
([be9cd94](be9cd94))
* **sdk:** better control which classes we expose
([#254](#254))
([e00eeaf](e00eeaf))
* **sdk:** DSPX-1037 update sdk api
([#249](#249))
([f2e1307](f2e1307))
* **sdk:** expose method to build an http client
([#256](#256))
([2cac97c](2cac97c))
* **sdk:** switch to `connect-rpc` for GRPC
([#244](#244))
([ff36a1d](ff36a1d))


### Bug Fixes

* **sdk:** add coverage
([#258](#258))
([e6ad1bc](e6ad1bc))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants