-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Certificates & Obligations #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pecific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`.
Summary of ChangesHello @pflynn-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing build consistency, updating copyright information, and evolving the Protobuf schemas for key management and policy enforcement. Key changes include pinning critical build dependencies, introducing new identifier types, adding fields to support legacy keys and certificate management, and marking older KAS assignment RPCs for deprecation in favor of a more robust Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…pecific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request pins development dependencies to ensure consistent builds and updates a large number of auto-generated files from protobuf definitions. The dependency pinning is a good practice for reproducibility. The generated code reflects significant API evolution, including the deprecation of old fields and RPCs, the introduction of new features like certificate and obligation management, and safety improvements to 'unsafe' operations. The update to the protobuf generation script also enhances build robustness. The changes appear solid and represent a positive step forward for the project.
|
This pull request adds generated TypeScript files for new and updated Protobuf definitions (https://github.com/opentdf/platform/releases/tag/protocol%2Fgo%2Fv0.12.0), introduces new types and services for entity and entity resolution, and includes some minor dependency and copyright updates.
Protobuf Type and Schema Additions:
IdNameIdentifier
andIdFqnIdentifier
(with their schemas) tocommon_pb.ts
, and updated the schema indices forMetadata
andMetadataMutable
to accommodate these additions. [1]](#), [2]](#), [3]](#))entity_pb.ts
that defines types and schemas forToken
,Entity
,EntityChain
, and theEntity_Category
enum. ([lib/src/platform/entity/entity_pb.tsR1-R154](#))entity_resolution_pb.ts
for entity resolution v2, defining types and schemas forEntityRepresentation
,ResolveEntitiesRequest/Response
,EntityNotFoundError
,CreateEntityChainsFromTokensRequest/Response
, and theEntityResolutionService
service definition. ([lib/src/platform/entityresolution/v2/entity_resolution_pb.tsR1-R170](#))Dependency and Copyright Updates:
@bufbuild/buf
and@bufbuild/protoc-gen-es
inpackage.json
to exact versions instead of using caret ranges, ensuring reproducible builds.annotations_pb.ts
andhttp_pb.ts
. [1]](#), [2]](#))http_pb.ts
(likely due to regeneration with a new year or tool version).