Skip to content

Conversation

pflynn-virtru
Copy link
Member

@pflynn-virtru pflynn-virtru commented Oct 15, 2025

This pull request adds generated TypeScript files for new and updated Protobuf definitions (https://github.com/opentdf/platform/releases/tag/protocol%2Fgo%2Fv0.12.0), introduces new types and services for entity and entity resolution, and includes some minor dependency and copyright updates.

Protobuf Type and Schema Additions:

  • Added new types IdNameIdentifier and IdFqnIdentifier (with their schemas) to common_pb.ts, and updated the schema indices for Metadata and MetadataMutable to accommodate these additions. [1]](#), [2]](#), [3]](#))
  • Added a new generated file entity_pb.ts that defines types and schemas for Token, Entity, EntityChain, and the Entity_Category enum. ([lib/src/platform/entity/entity_pb.tsR1-R154](#))
  • Added a new generated file entity_resolution_pb.ts for entity resolution v2, defining types and schemas for EntityRepresentation, ResolveEntitiesRequest/Response, EntityNotFoundError, CreateEntityChainsFromTokensRequest/Response, and the EntityResolutionService service definition. ([lib/src/platform/entityresolution/v2/entity_resolution_pb.tsR1-R170](#))

Dependency and Copyright Updates:

  • Pinned the versions of @bufbuild/buf and @bufbuild/protoc-gen-es in package.json to exact versions instead of using caret ranges, ensuring reproducible builds.
  • Updated copyright years from 2024 to 2025 in annotations_pb.ts and http_pb.ts. [1]](#), [2]](#))
  • Minor change in the generated file descriptor string in http_pb.ts (likely due to regeneration with a new year or tool version).

…pecific versions.

- Update copyright notices in `http_pb.ts` and `validate_pb.ts`.
@pflynn-virtru pflynn-virtru requested review from a team as code owners October 15, 2025 16:09
Copy link

Summary of Changes

Hello @pflynn-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing build consistency, updating copyright information, and evolving the Protobuf schemas for key management and policy enforcement. Key changes include pinning critical build dependencies, introducing new identifier types, adding fields to support legacy keys and certificate management, and marking older KAS assignment RPCs for deprecation in favor of a more robust PublicKey approach. These updates aim to improve the stability and future extensibility of the platform's policy and key access services.

Highlights

  • Dependency Pinning: The @bufbuild/buf and @bufbuild/protoc-gen-es dependencies have been updated to specific, pinned versions (1.52.1 and 2.2.5 respectively) in lib/package.json to ensure consistent and reproducible builds.
  • Copyright Year Update: Copyright notices in lib/src/platform/google/api/annotations_pb.ts and lib/src/platform/google/api/http_pb.ts have been updated from 2024 to 2025.
  • Protobuf Schema Enhancements: Several Protobuf schemas across common_pb.ts, kasregistry_pb.ts, key_management_pb.ts, namespaces_pb.ts, objects_pb.ts, and unsafe_pb.ts have been updated. This includes the addition of new identifier messages (IdNameIdentifier, IdFqnIdentifier), new fields (e.g., legacy for keys, manager for key provider configs, root_certs for namespaces, obligations for values), and new messages for key mappings and certificate management.
  • Deprecation of Old KAS Assignment RPCs: RPCs and related messages for assigning/removing Key Access Servers (AssignKeyAccessServerToAttribute, RemoveKeyAccessServerFromAttribute, etc.) have been marked as deprecated, with a recommendation to utilize PublicKey based assignments instead. Several selector messages have also been deprecated as they were never utilized.
  • Build Script Improvement: The scripts/platform.sh build script has been enhanced to explicitly use the local protoc-gen-es from node_modules by modifying the PATH environment variable, ensuring correct code generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

…pecific versions.

- Update copyright notices in `http_pb.ts` and `validate_pb.ts`.
@pflynn-virtru pflynn-virtru changed the title Pin dependencies and update copyright notices feat: Namespace fetch Oct 15, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins development dependencies to ensure consistent builds and updates a large number of auto-generated files from protobuf definitions. The dependency pinning is a good practice for reproducibility. The generated code reflects significant API evolution, including the deprecation of old fields and RPCs, the introduction of new features like certificate and obligation management, and safety improvements to 'unsafe' operations. The update to the protobuf generation script also enhances build robustness. The changes appear solid and represent a positive step forward for the project.

@pflynn-virtru pflynn-virtru changed the title feat: Namespace fetch feat: Namespace & Obligations Oct 15, 2025
Copy link

@pflynn-virtru pflynn-virtru changed the title feat: Namespace & Obligations feat: Certificates & Obligations Oct 15, 2025
@pflynn-virtru pflynn-virtru merged commit 688c304 into main Oct 15, 2025
17 checks passed
@pflynn-virtru pflynn-virtru deleted the feature/namespace branch October 15, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants