[#650] Replace document type with document category #143
Conversation
There was a problem hiding this comment.
I don't like that we have database IDs hardcoded in our migrations. This way, if database IDs in either Explorer or API ever change, the migrations will silently fail.
Can't we replace the IDs with name+group pairs, and instead of doing operations by ID we do them by getting the ID in a subquery using the pairs above?
|
|
||
| const documentCategories = [ | ||
| { | ||
| id: 19, |
There was a problem hiding this comment.
I really don't like the idea of hardcoding IDs into migrations. Isn't there any other way of doing it? Maybe we can further match explorer and API categories by name+group pairs, which are unique.
| const Promise = require('bluebird'); | ||
|
|
||
| const typeToCategoryMapping = { | ||
| blank_consent_form: 33, |
There was a problem hiding this comment.
Same issue I have with hardcoded IDs into migrations.
There was a problem hiding this comment.
@nightsh I figured the name and group would probably change more often than the ID, wouldn't you agree?
4 participants
opentrials/opentrials#650