Skip to content

Conversation

sugchand
Copy link
Contributor

Adding a self-guide for configuring native userspace tunneling in OVS
with/without DPDK ports. This document also provides necessary debugging
commands to identify userspace tunneling issues in OVS.

Signed-off-by: Sugesh Chandran sugesh.chandran@intel.com

@ddiproietto
Copy link
Contributor

Thanks for doing this!

This appears to add the guide to the website, but the page doesn't match the style of the rest of the site (it is rendered as simple text). These commits (e7f7d78 and a8e6f64) should make more clear how to add an entry to the website. Some comments:

  • I would rename support/config-cookbooks/userspace-tunneling/README-native-tunneling-DPDK.md to support/config-cookbooks/userspace-tunneling/index.md
  • The page needs to have an header to be rendered correctly. Something like:
---
layout: page
status: publish
published: true
title: Openvswitch Native tunneling configuration guide
author: sugchand
date: 2015-10-22
categories:
- Uncategorized
tags: []
comments: []
---
  • A link to the page should be placed in the navbar, by editing _data/nav.yml
  • The markdown is not rendered correctly (the commands are in bold instead of monospace, the ordered list items are not numbered properly). Github has a good cheatsheet that explains their markdown syntax https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet
  • I would remove sudo from the commands. The other configuration cookbooks do not have it.

_BUILD explains how to test your modifications.

Would you mind fixing it and submitting another pull request? Again, thank you for this contribution!

@sugchand sugchand closed this Oct 23, 2015
@sugchand
Copy link
Contributor Author

Hi Daniele,

Thank you for your comments on the patch. It seems like some of the markup symbols are not handled properly by the website parser though it works fine on other editors/browser plugins. So I reworked on the patch, tested locally and submitted the new pull request (#24) . Can you please review the same??

Once again thank you for the pointers to make the necessary changes and test them.
Regards
_Sugesh

@sugchand
Copy link
Contributor Author

Hi Daniele,
I have incorporated all the comments and created a new pull request as below,
#24

Can you please have a look on this new request and let me know your comments if any.

Regards
_Sugesh

From: ddiproietto [mailto:notifications@github.com]
Sent: Thursday, October 22, 2015 9:44 PM
To: openvswitch/openvswitch.github.io
Cc: Chandran, Sugesh
Subject: Re: [openvswitch.github.io] Detailed documentation for configuring native userspace-tunneling in OVS. (#23)

Thanks for doing this!

This appears to add the guide to the website, but the page doesn't match the style of the rest of the site (it is rendered as simple text). These commits (e7f7d78e7f7d78 and a8e6f64a8e6f64) should make more clear how to add an entry to the website. Some comments:

  • I would rename support/config-cookbooks/userspace-tunneling/README-native-tunneling-DPDK.md to support/config-cookbooks/userspace-tunneling/index.md
  • The page needs to have an header to be rendered correctly. Something like:

layout: page

status: publish

published: true

title: Openvswitch Native tunneling configuration guide

author: sugchand

date: 2015-10-22

categories:

  • Uncategorized

tags: []

comments: []


  • A link to the page should be placed in the navbar, by editing _data/nav.yml
  • The markdown is not rendered correctly (the commands are in bold instead of monospace, the ordered list items are not numbered properly). Github has a good cheatsheet that explains their markdown syntax https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet
  • I would remove sudo from the commands. The other configuration cookbooks do not have it.

_BUILD<../blob/master/_BUILD> explains how to test your modifications.

Would you mind fixing it and submitting another pull request? Again, thank you for this contribution!


Reply to this email directly or view it on GitHubhttps://github.com//pull/23#issuecomment-150350920.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants