-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration options for parsing alternative input tokens and full-width unicode character support. #1174
Conversation
…, and for converting full-width unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial changes needed. Typos 'copyihng' and 'Fullk' in both changed files.
@drdrew42, thanks! I have fixed the typos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with openwebwork/pg#518 and these settings work as intended, as far as I tested in terms of enabling/disabling support for:
- Unicode minus and Unicode infinity
- Full width open/close parenthesis (Attempt to support some standard math operators when included in answers using Unicode characters pg#517 (comment))
Thanks @dpvc !!!
@taniwallach, thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
…ll-width unicode character support
Everyone approved this, and nearly everyone approved the corresponding openwebwork/pg#518. So I'm going to merge. I'm trying to make a dent in the PR backlog this week. |
This is the companion PR to openwebwork/pg#518 that addresses the issues in openwebwork/pg#517. This PR adds the needed course configuration parameters to allow course-wide control of the new features.