Add configuration options for parsing alternative input tokens and full-width unicode character support. #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and for converting full-width unicode characters
drdrew42
requested changes
Jan 16, 2021
|
@drdrew42, thanks! I have fixed the typos. |
drdrew42
approved these changes
Jan 16, 2021
taniwallach
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
I tested this with openwebwork/pg#518 and these settings work as intended, as far as I tested in terms of enabling/disabling support for:
- Unicode minus and Unicode infinity
- Full width open/close parenthesis (Attempt to support some standard math operators when included in answers using Unicode characters pg#517 (comment))
Thanks @dpvc !!!
|
@taniwallach, thanks for the review. |
Alex-Jordan
approved these changes
Jan 27, 2021
…ll-width unicode character support
|
Everyone approved this, and nearly everyone approved the corresponding openwebwork/pg#518. So I'm going to merge. I'm trying to make a dent in the PR backlog this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR to openwebwork/pg#518 that addresses the issues in openwebwork/pg#517. This PR adds the needed course configuration parameters to allow course-wide control of the new features.