Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Python3 (system) packages should be installed if false #393 #394

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

broadstack-au
Copy link
Contributor

@broadstack-au broadstack-au commented Sep 1, 2022

is_version returns a boolean.
Checking for string "False\n" resulted in system python3 packages not being installed

Target Host:

  Ubuntu: 20.04
  Python: 3.8.10

Executing Host (ansible run from):

  ansible [core 2.13.2]
  python version = 3.10.6 (main, Aug 11 2022, 13:49:25) [Clang 13.1.6 (clang-1316.0.21.2.5)]
  jinja version = 3.1.2

Fixes #393

@broadstack-au broadstack-au changed the title [fix] python3 (system) packages should be installed if false [fix] Python3 (system) packages should be installed if false Sep 1, 2022
@broadstack-au broadstack-au changed the title [fix] Python3 (system) packages should be installed if false [fix] Python3 (system) packages should be installed if false #393 Sep 1, 2022
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to amend the commit message to something like:

[fix] Fixed openwisp2_should_install_python_37 false test

@nemesifier nemesifier merged commit a12068f into openwisp:master Sep 1, 2022
@nemesifier
Copy link
Member

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants