[openvpn] Improve parse_data to raise exception if something goes wrong #58 #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdgeKing810
force-pushed
the
master
branch
6 times, most recently
from
44006f6 to
9a3c1f8
Compare
|
Getting errors in travis. 😩 |
EdgeKing810
force-pushed
the
master
branch
3 times, most recently
from
1a9f335 to
3f39f5d
Compare
nemesifier
requested changes
Dec 9, 2018
|
There isn't now 😂 |
EdgeKing810
force-pushed
the
master
branch
3 times, most recently
from
45ebb64 to
1d35041
Compare
|
Idk if I did it well... I based myself on some code from |
nemesifier
requested changes
Dec 9, 2018
EdgeKing810
force-pushed
the
master
branch
6 times, most recently
from
fded3cf to
cfeca5f
Compare
|
Errors and errors... |
nemesifier
reviewed
Dec 10, 2018
|
Travis build is fixed now... I'll need a review on what to improve or do more :/ |
nemesifier
requested changes
Dec 10, 2018
EdgeKing810
force-pushed
the
master
branch
3 times, most recently
from
048b626 to
6bd23b6
Compare
|
@nemesisdesign I'm getting a |
nemesifier
requested changes
Dec 10, 2018
EdgeKing810
force-pushed
the
master
branch
3 times, most recently
from
2784126 to
b68e5f1
Compare
nemesifier
reviewed
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCI Task: https://codein.withgoogle.com/dashboard/task-instances/5302984465448960/
(P.S. It's now that I'm working on the tests, need some help from Travis)