Join GitHub today
Add "enum" for countries #52
That shouldn't be an issue because the library supplies the correct value upon rendering/generation.
But I would like to accept your patch in order to address the mismatch so the implementation would become cleaner, I'm trying your patch but lots of things go wrong.
Have you tried running unit tests as explained in the README?
I see many failing tests with an error which I think it's hard to overcome: OpenWRT has quite a few timezones of different areas which have the same value, but specifying an
Supplying a list which has duplicate values to
To understand what I'm trying to say, run this command:
The other change to countries should easier to include.
See the failing build:
You just have to remove a few trailing spaces from the indicated lines.
Then when you are done, do the following to squash your commits:
Leave the last commit untouched and set the previous ones as "squash", then provide a better commit message and save, then push to your repository using
Thank you @zachantre!