Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: print full traceback when verbose #99

Merged
merged 2 commits into from Jul 4, 2018

Conversation

@edoput
Copy link
Contributor

@edoput edoput commented Sep 6, 2017

Every other error from the netjson library has a custom error reporting but when I am working on a new feature it's easy to mess things up and I wuold like to know what and why.

This PR should print the full traceback for error others than ValidationError when I use the verbose flag.

This should get rid of the "remove the last exception handling lines" during development

@coveralls
Copy link

@coveralls coveralls commented Sep 6, 2017

Coverage Status

Coverage remained the same at 99.931% when pulling 20bcb38 on EdoPut:record-traceback-separately into a2611ef on openwisp:master.

Copy link
Member

@nemesisdesign nemesisdesign left a comment

@edoput sorry I forgot about this one

@nemesisdesign nemesisdesign merged commit 778def3 into openwisp:master Jul 4, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants