Removes tracegen #1118
Merged
Removes tracegen #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracegen was a tool we used to use to populate zipkin when someone had no instrumented apps. It would create a number of traces based on latin words. Since then, we have increasingly sophisticated and relevant self-tracing setup, which in the java project extends all the way to cassandra. Moreover, we have spigo, which now includes zipkin scripts to create large amounts of realistic traces, and instrumentation-specific examples from Brave and Sleuth. Considering the better alternatives, we should stop maintaining tracegen https://github.com/adrianco/spigo https://github.com/openzipkin/brave-resteasy-example https://github.com/spring-cloud-samples/brewery
| # start the web server in a new terminal session or tab | ||
| $ ./bin/web | ||
| # create dummy traces | ||
| $ ./bin/tracegen |
There was a problem hiding this comment.
Not blocker: I'd love to see a one (two?) liner to generate traces into Zipkin with Spigo here to replace tracegen.
There was a problem hiding this comment.
spigo demos always use docker, so I've moved this to a new issue openzipkin-attic/docker-zipkin-dependencies#6 I think there are some ways we can help with spigo to reduce steps (possibly making it report directly as opposed to generating files similar to adrianco/spigo#67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracegen was a tool we used to use to populate zipkin when someone had
no instrumented apps. It would create a number of traces based on latin
words.
Since then, we have increasingly sophisticated and relevant self-tracing
setup, which in the java project extends all the way to cassandra.
Moreover, we have spigo, which now includes zipkin scripts to create
large amounts of realistic traces, and instrumentation-specific examples
from Brave and Sleuth.
Considering the better alternatives, we should stop maintaining tracegen
https://github.com/adrianco/spigo
https://github.com/openzipkin/brave-resteasy-example
https://github.com/spring-cloud-samples/brewery