Skip to content

Conversation

estroz
Copy link
Member

@estroz estroz commented Nov 25, 2019

  • go.mod,go.sum: bump k8s deps to kubernetes-1.16.2
  • pkg/validation/internal: respect new ValidateCustomResourceDefinition argument GroupVersion

/cc @njhale @gallettilance @awgreene

pkg/validation/internal: respect new ValidateCustomResourceDefinition
argument GroupVersion
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2019
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

/lgtm

Note: I do think that in the near future we should have prow or travis run unit tests on our PRs for this repo.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@njhale njhale merged commit 9066a6e into operator-framework:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants