[WIP] move operator-registry/pkg/{api,registry} here #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/{api,registry}
to pkg/registry/{api,manifests}, respectively
pkg/internal: use pkg/registry/manifests types and add temporary
conversion func, which should be removed one operator-registry
begins using api types
pkg/manifests: use pkg/registry/manifests types
go.mod,go.sum: revendor after changes
openshift-ci-robot
added
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/operator-framework/api/pull/3/files#r343686375
The types moved here are those necessary for operator-registry to share api code.
However I'm in the process of testing whether cyclical dependencies still occur and if we need to move more over to avoid thoseThese changes compile with operator-registry using api as a local module. Changes so far:github.com/operator-framework/operator-registry/pkg/{api,registry}topkg/registry/{api,manifests}, respectivelypkg/registry/manifeststypes and add temporary conversion func, which should be removed one operator-registry begins using api typespkg/registry/manifeststypesContains changes from/blocked by #6
/cc @gallettilance @njhale