Skip to content

add shortName for operatorcondition #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2021
Merged

add shortName for operatorcondition #87

merged 1 commit into from
Feb 2, 2021

Conversation

jianzhangbjz
Copy link
Contributor

There is no condition described in operator-framework/olm-docs#83, so add the condition as the short name of the operatorcondition

[root@preserve-olm-env data]#  oc get condition
error: the server doesn't have a resource type "condition"

[root@preserve-olm-env data]#  oc get operatorcondition
No resources found in default namespace.

@jianzhangbjz
Copy link
Contributor Author

/assign @awgreene

awgreene
awgreene requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jianzhangbjz - one request to make sure that the change isn't removed when CRDs are generated.

@awgreene
Copy link
Member

/approve

@awgreene awgreene added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@jianzhangbjz
Copy link
Contributor Author

@benluddy Could you help have a review? Thanks!

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2021
@jianzhangbjz
Copy link
Contributor Author

Both approved and lgtm labels added, but this PR still not be merged, anything else needed?

@awgreene awgreene merged commit bf75ca7 into operator-framework:master Feb 2, 2021
@jianzhangbjz jianzhangbjz deleted the shortname branch February 3, 2021 00:53
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgreene awgreene awgreene requested changes

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@ecordell ecordell

@awgreene awgreene

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jianzhangbjz @awgreene @ecordell @openshift-ci-robot