Skip to content

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Dec 4, 2020

No description provided.

Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really well written @awgreene ! Just had one comment and a nit otherwise lgtm


## OperatorConditions

OLM introduced a new [CustomResourceDefinition](https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/) called the [OperatorCondition](https://github.com/operator-framework/api/blob/master/crds/operators.coreos.com_operatorconditions.yaml) allowing operators to communicate conditions to OLM. There are a set of "OLM Supported Conditions" which influence OLM's management of the operator when present in the OperatorCondition's [Status.Conditions](https://github.com/operator-framework/api/blob/b55a341f6560db4adec39d69aab1ff3092ea202a/pkg/operators/v1/operatorcondition_types.go#L22) array.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably include the CRD here instead of pointing to the codebase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: There are a set of "OLM Supported Conditions": did you mean for the OLM Supported Conditions to be in bold?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: There are a set of "OLM Supported Conditions": did you mean for the OLM Supported Conditions to be in bold?

No, I'm using it as a term to refer to a subset of conditions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably include the CRD here instead of pointing to the codebase.

Done.

@awgreene awgreene force-pushed the operator-conditions branch from 4498095 to f1cde2e Compare December 7, 2020 13:55
@anik120
Copy link
Contributor

anik120 commented Dec 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2020
@anik120 anik120 merged commit d624a9f into operator-framework:master Dec 7, 2020
@ecordell
Copy link
Member

ecordell commented Dec 7, 2020


```yaml
apiVersion: operators.coreos.com/v1
kind: Condition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the operatorcondition?

@jianzhangbjz
Copy link
Contributor

/QE-approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants