Skip to content

rename-bin-tool and fix run it outside of the cloned dir #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2021
Merged

rename-bin-tool and fix run it outside of the cloned dir #16

merged 1 commit into from
May 11, 2021

Conversation

camilamacedo86
Copy link
Collaborator

Description

  • Rename bin tool from audit to audit-tool
  • Fix the binary works outside of the cloned directory

Motivation
OSX systems have in the sbin a bin called audit which generates a conflict to install the bin locally

@coveralls
Copy link

Pull Request Test Coverage Report for Build 828922612

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 1.209%
Totals Coverage Status
Change from base Build 828633622: 0.0%
Covered Lines: 16
Relevant Lines: 1323
💛 - Coveralls

gallettilance
gallettilance approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@camilamacedo86 camilamacedo86 merged commit e04abb0 into operator-framework:main May 11, 2021
@camilamacedo86 camilamacedo86 deleted the fix-tool branch May 11, 2021 19:56
@camilamacedo86 camilamacedo86 mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallettilance gallettilance gallettilance approved these changes

@bentito bentito Awaiting requested review from bentito

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @coveralls @gallettilance