Skip to content

fixes, cleanups, add re-gen #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

fixes, cleanups, add re-gen #21

merged 1 commit into from
May 12, 2021

Conversation

camilamacedo86
Copy link
Collaborator

@camilamacedo86 camilamacedo86 commented May 12, 2021 •
edited
Loading

Description

@coveralls
Copy link

coveralls commented May 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 834986542

  • 0 of 25 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 1.188%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/reports/channels/data.go 0 1 0.0%
pkg/helpers.go 0 24 0.0%
Totals Coverage Status
Change from base Build 832961854: -0.02%
Covered Lines: 16
Relevant Lines: 1347
💛 - Coveralls

@camilamacedo86 camilamacedo86 changed the title small fix as follow up and re-gen reports small fix as follow up and regen reports May 12, 2021
@camilamacedo86 camilamacedo86 changed the title small fix as follow up and regen reports fixes, cleanups, add e2e test and re-gen May 12, 2021
@camilamacedo86 camilamacedo86 changed the title fixes, cleanups, add e2e test and re-gen fixes, cleanups, add and re-gen May 12, 2021
@camilamacedo86
fixes, cleanups, add and re-gen
68b4e2d 
- fix errors found as follow up of #16 (the fix was missing be done for all commands)
- fix like query for channels
- re-gen all reports
- cleanups
- improve the generate targets
- add e2e tests

dd

dd
@camilamacedo86 camilamacedo86 changed the title fixes, cleanups, add and re-gen fixes, cleanups, add re-gen May 12, 2021
@camilamacedo86
Copy link
Collaborator Author

I am merging this one without review because the main is broken and it will fix.
c/c @jmccormick2001

@camilamacedo86 camilamacedo86 merged commit ca2a3e4 into operator-framework:main May 12, 2021
@camilamacedo86 camilamacedo86 deleted the fix-regen branch May 12, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camilamacedo86 @coveralls