Revert "add PDB to make sure at least 1 pod is always available during upgrade (#2362)"

This is causing an issue with multi-node upgrades downstream.

This reverts commit 5ed8cf4.

Author: tmshort

hack/test/install-prometheus.sh

@@ -38,11 +38,8 @@ echo "Patching namespace to ${PROMETHEUS_NAMESPACE}..."
 echo "Applying Prometheus base..."
 kubectl apply -k "$TMPDIR" --server-side
 
-echo "Waiting for Prometheus Operator deployment to become available..."
-kubectl wait --for=condition=Available deployment/prometheus-operator -n "$PROMETHEUS_NAMESPACE" --timeout=180s
-
 echo "Waiting for Prometheus Operator pod to become ready..."
-kubectl wait --for=condition=Ready pod -n "$PROMETHEUS_NAMESPACE" -l app.kubernetes.io/name=prometheus-operator --timeout=120s
+kubectl wait --for=condition=Ready pod -n "$PROMETHEUS_NAMESPACE" -l app.kubernetes.io/name=prometheus-operator
 
 echo "Applying prometheus Helm chart..."
 ${HELM} template prometheus helm/prometheus ${PROMETHEUS_VALUES} | sed "s/cert-git-version/cert-${VERSION}/g" | kubectl apply -f -

helm/olmv1/templates/poddisruptionbudget-olmv1-system-catalogd.yml

@@ -12,9 +12,6 @@ options:
     features:
       enabled: []
       disabled: []
-    podDisruptionBudget:
-      enabled: true
-      minAvailable: 1
   catalogd:
     enabled: true
     deployment:
@@ -23,9 +20,6 @@ options:
     features:
       enabled: []
       disabled: []
-    podDisruptionBudget:
-      enabled: true
-      minAvailable: 1
   certManager:
     enabled: false
   e2e:

helm/olmv1/templates/poddisruptionbudget-olmv1-system-operator-controller.yml

@@ -87,40 +87,6 @@ spec:
     - Ingress
     - Egress
 ---
-# Source: olmv1/templates/poddisruptionbudget-olmv1-system-catalogd.yml
-apiVersion: policy/v1
-kind: PodDisruptionBudget
-metadata:
-  name: catalogd-controller-manager
-  namespace: olmv1-system
-  labels:
-    app.kubernetes.io/name: catalogd
-    app.kubernetes.io/part-of: olm
-  annotations:
-    olm.operatorframework.io/feature-set: experimental-e2e
-spec:
-  minAvailable: 1
-  selector:
-    matchLabels:
-      control-plane: catalogd-controller-manager
----
-# Source: olmv1/templates/poddisruptionbudget-olmv1-system-operator-controller.yml
-apiVersion: policy/v1
-kind: PodDisruptionBudget
-metadata:
-  name: operator-controller-controller-manager
-  namespace: olmv1-system
-  labels:
-    app.kubernetes.io/name: operator-controller
-    app.kubernetes.io/part-of: olm
-  annotations:
-    olm.operatorframework.io/feature-set: experimental-e2e
-spec:
-  minAvailable: 1
-  selector:
-    matchLabels:
-      control-plane: operator-controller-controller-manager
----
 # Source: olmv1/templates/serviceaccount-olmv1-system-common-controller-manager.yml
 apiVersion: v1
 kind: ServiceAccount

helm/olmv1/values.yaml

@@ -87,40 +87,6 @@ spec:
     - Ingress
     - Egress
 ---
-# Source: olmv1/templates/poddisruptionbudget-olmv1-system-catalogd.yml
-apiVersion: policy/v1
-kind: PodDisruptionBudget
-metadata:
-  name: catalogd-controller-manager
-  namespace: olmv1-system
-  labels:
-    app.kubernetes.io/name: catalogd
-    app.kubernetes.io/part-of: olm
-  annotations:
-    olm.operatorframework.io/feature-set: experimental
-spec:
-  minAvailable: 1
-  selector:
-    matchLabels:
-      control-plane: catalogd-controller-manager
----
-# Source: olmv1/templates/poddisruptionbudget-olmv1-system-operator-controller.yml
-apiVersion: policy/v1
-kind: PodDisruptionBudget
-metadata:
-  name: operator-controller-controller-manager
-  namespace: olmv1-system
-  labels:
-    app.kubernetes.io/name: operator-controller
-    app.kubernetes.io/part-of: olm
-  annotations:
-    olm.operatorframework.io/feature-set: experimental
-spec:
-  minAvailable: 1
-  selector:
-    matchLabels:
-      control-plane: operator-controller-controller-manager
----
 # Source: olmv1/templates/serviceaccount-olmv1-system-common-controller-manager.yml
 apiVersion: v1
 kind: ServiceAccount

manifests/experimental-e2e.yaml

@@ -87,40 +87,6 @@ spec:
     - Ingress
     - Egress
 ---
-# Source: olmv1/templates/poddisruptionbudget-olmv1-system-catalogd.yml
-apiVersion: policy/v1
-kind: PodDisruptionBudget
-metadata:
-  name: catalogd-controller-manager
-  namespace: olmv1-system
-  labels:
-    app.kubernetes.io/name: catalogd
-    app.kubernetes.io/part-of: olm
-  annotations:
-    olm.operatorframework.io/feature-set: standard-e2e
-spec:
-  minAvailable: 1
-  selector:
-    matchLabels:
-      control-plane: catalogd-controller-manager
----
-# Source: olmv1/templates/poddisruptionbudget-olmv1-system-operator-controller.yml
-apiVersion: policy/v1
-kind: PodDisruptionBudget
-metadata:
-  name: operator-controller-controller-manager
-  namespace: olmv1-system
-  labels:
-    app.kubernetes.io/name: operator-controller
-    app.kubernetes.io/part-of: olm
-  annotations:
-    olm.operatorframework.io/feature-set: standard-e2e
-spec:
-  minAvailable: 1
-  selector:
-    matchLabels:
-      control-plane: operator-controller-controller-manager
----
 # Source: olmv1/templates/serviceaccount-olmv1-system-common-controller-manager.yml
 apiVersion: v1
 kind: ServiceAccount

manifests/experimental.yaml

@@ -87,40 +87,6 @@ spec:
     - Ingress
     - Egress
 ---
-# Source: olmv1/templates/poddisruptionbudget-olmv1-system-catalogd.yml
-apiVersion: policy/v1
-kind: PodDisruptionBudget
-metadata:
-  name: catalogd-controller-manager
-  namespace: olmv1-system
-  labels:
-    app.kubernetes.io/name: catalogd
-    app.kubernetes.io/part-of: olm
-  annotations:
-    olm.operatorframework.io/feature-set: standard
-spec:
-  minAvailable: 1
-  selector:
-    matchLabels:
-      control-plane: catalogd-controller-manager
----
-# Source: olmv1/templates/poddisruptionbudget-olmv1-system-operator-controller.yml
-apiVersion: policy/v1
-kind: PodDisruptionBudget
-metadata:
-  name: operator-controller-controller-manager
-  namespace: olmv1-system
-  labels:
-    app.kubernetes.io/name: operator-controller
-    app.kubernetes.io/part-of: olm
-  annotations:
-    olm.operatorframework.io/feature-set: standard
-spec:
-  minAvailable: 1
-  selector:
-    matchLabels:
-      control-plane: operator-controller-controller-manager
----
 # Source: olmv1/templates/serviceaccount-olmv1-system-common-controller-manager.yml
 apiVersion: v1
 kind: ServiceAccount