Skip to content

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Oct 7, 2025

Description

This PR adds experimental API and feature-gated functionality to support direct bundle installs, which avoid the need to dereference from a ClusterCatalog.

@perdasilva mentioned he put up #2252, and it reminded me that I had a commit like that in my really old shift-week PR from last year. This PR is mainly a rebase of that one commit, just for reference purposes.

@perdasilva feel free to do as you please with this PR! Ignore it, merge it, beg/borrow/steal from it, or anything in between!

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2025
Copy link

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e799af7
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68e54b562094290008c6edc4
😎 Deploy Preview https://deploy-preview-2255--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 21.42857% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.46%. Comparing base (029484d) to head (e799af7).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/operator-controller/resolve/bundle.go 0.00% 38 Missing ⚠️
api/v1/zz_generated.deepcopy.go 0.00% 13 Missing and 1 partial ⚠️
internal/operator-controller/resolve/resolver.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
+ Coverage   70.35%   72.46%   +2.11%     
==========================================
  Files          89       90       +1     
  Lines        8747     8815      +68     
==========================================
+ Hits         6154     6388     +234     
+ Misses       2207     2010     -197     
- Partials      386      417      +31     
Flag Coverage Δ
e2e 38.95% <11.76%> (?)
experimental-e2e 45.81% <19.11%> (-0.20%) ⬇️
unit 57.51% <2.85%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…y from their image reference

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford force-pushed the direct-bundle-install branch from 3b9eb66 to e799af7 Compare October 7, 2025 17:18
@perdasilva
Copy link
Contributor

Closing in favor of #2260

@perdasilva perdasilva closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants