Skip to content

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Oct 10, 2025

Description

Drops ClusterExtensionRevision Complete condition.

This isn't necessarily a breaking change since Boxcutter is behind a feature flag.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva requested a review from a team as a code owner October 10, 2025 08:32
@openshift-ci openshift-ci bot requested review from anik120 and grokspawn October 10, 2025 08:32
Copy link

netlify bot commented Oct 10, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 78e1360
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68e8c4aa5458eb0008ab6b6c
😎 Deploy Preview https://deploy-preview-2260--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thetechnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva perdasilva marked this pull request as draft October 10, 2025 08:32
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2025
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.87%. Comparing base (95c5934) to head (78e1360).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
- Coverage   72.87%   72.87%   -0.01%     
==========================================
  Files          88       88              
  Lines        8733     8721      -12     
==========================================
- Hits         6364     6355       -9     
+ Misses       1955     1953       -2     
+ Partials      414      413       -1     
Flag Coverage Δ
e2e 39.31% <0.00%> (+0.05%) ⬆️
experimental-e2e 46.23% <100.00%> (-0.09%) ⬇️
unit 57.96% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva changed the title Drop ClusterExtensionRevision Complete condition 🌱 Drop ClusterExtensionRevision Complete condition Oct 10, 2025
@perdasilva perdasilva changed the title 🌱 Drop ClusterExtensionRevision Complete condition ⚠️ Drop ClusterExtensionRevision Complete condition Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant