Skip to content

🌱 OPRUN-4194: Allow openshift catalog versions to be configurable via helm #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

🌱 OPRUN-4194: Allow openshift catalog versions to be configurable via helm #2264

merged 1 commit into from
Oct 13, 2025
+6 −4

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 13, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner October 13, 2025 13:46
@openshift-ci openshift-ci bot requested review from OchiengEd and oceanc80 October 13, 2025 13:46
@netlify Netlify
Copy link

netlify bot commented Oct 13, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d5c0eb7
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68ed0afc297cf50008f7e742
😎 Deploy Preview https://deploy-preview-2264--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort tmshort mentioned this pull request Oct 13, 2025
Closed
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2025
@camilamacedo86
Copy link
Contributor

/lgtm

pedjak
pedjak reviewed Oct 13, 2025
View reviewed changes
helm/olmv1/values.yaml Outdated
enabled: false
# This can be one of: standard or experimental
featureSet: standard
catalogVersion: v4.20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about to make a struct like this:

catalog:
  version: v4.20

it opens up a room for future extension without having long descriptive variable names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did ponder that...

@tmshort
Copy link
Contributor Author

tmshort commented Oct 13, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@tmshort
Allow openshift catalog versions to be configurable via helm
d5c0eb7 
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort force-pushed the updatable-catalog-versions branch from 8cebfa4 to d5c0eb7 Compare October 13, 2025 14:21
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Oct 13, 2025

/unhold
Ok, I actually put it under the openshift option, because it is openshift specific.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
pedjak
pedjak reviewed Oct 13, 2025
View reviewed changes
helm/olmv1/values.yaml
enabled: false
openshift:
enabled: false
catalogs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have mutiple catalogs with the same version or it should be

catalog:
  version: v4.20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought of this... and it doesn't matter too much.
I put it under openshift.

camilamacedo86
camilamacedo86 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Oct 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.06%. Comparing base (6604f2a) to head (d5c0eb7).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2264      +/-   ##
==========================================
+ Coverage   72.73%   73.06%   +0.32%     
==========================================
  Files          89       88       -1     
  Lines        8747     8738       -9     
==========================================
+ Hits         6362     6384      +22     
+ Misses       1968     1942      -26     
+ Partials      417      412       -5
Flag Coverage Δ
e2e 39.44% <ø> (+0.24%) ⬆️
experimental-e2e 46.83% <ø> (+0.96%) ⬆️
unit 58.01% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot bot merged commit 48d5ccd into operator-framework:main Oct 13, 2025
32 of 34 checks passed
@tmshort tmshort deleted the updatable-catalog-versions branch October 13, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedjak pedjak pedjak approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@oceanc80 oceanc80 Awaiting requested review from oceanc80

@OchiengEd OchiengEd Awaiting requested review from OchiengEd

Assignees

@pedjak pedjak

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort @camilamacedo86 @pedjak