Skip to content

Update CLI reference doc #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

Update CLI reference doc #3255

merged 1 commit into from
Jun 18, 2020

Conversation

hasbro17
Copy link
Contributor

Missing some CLI reference updates on the master branch.

Also not sure what's going on with the --project-version string reshuffling the args.

/cc @estroz

@hasbro17 hasbro17 mentioned this pull request Jun 17, 2020
Merged
@jberkhahn
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020
@hasbro17 hasbro17 force-pushed the update-CLI-reference branch from 0035e0d to f08e75b Compare June 18, 2020 00:02
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@hasbro17
Copy link
Contributor Author

Leaving out the update for --project-version help text update for this one since that can change on different invocations of regenerating the CLI reference doc.
That'll be fixed here kubernetes-sigs/kubebuilder#1564

estroz
estroz approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@hasbro17 hasbro17 merged commit 275488d into operator-framework:master Jun 18, 2020
@hasbro17 hasbro17 deleted the update-CLI-reference branch June 18, 2020 00:17
@jberkhahn jberkhahn mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jberkhahn jberkhahn jberkhahn approved these changes

+1 more reviewer

@estroz estroz estroz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jberkhahn jberkhahn

@estroz estroz

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hasbro17 @jberkhahn @estroz @openshift-ci-robot