Skip to content

Conversation

jberkhahn
Copy link
Contributor

Hey there, applying for reviewership of Operator-SDK

Sponsor: @estroz
Member for at least 3 months ✔️
Primary reviewer of 5 PRs:
#3096
#3668
#3879
#3708 (this is an issue but involved a substantial amount of investigation)
#2893

Reviewed/Merged 20 PRs:
#3096
#3668
#3879
#3708 (this is an issue but involved a substantial amount of investigation)
#2893
#3725
#3508
#3454
#3413
#3411
#3375
#3318
#3296
#3287
#3247
#2676
#2629
#3668
#3255
#3734

@estroz
Copy link
Member

estroz commented Sep 28, 2020

I'm sponsoring @jberkhahn to gain reviewer status.

Going to merge #3955 first.

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@asmacdo
Copy link
Member

asmacdo commented Sep 28, 2020

/lgtm

@asmacdo
Copy link
Member

asmacdo commented Sep 28, 2020

Before merge this will need to be altered to update the OWNERS_ALIAS file instead.

@jberkhahn
Copy link
Contributor Author

wait, so is #3955 being merged first or not?

@asmacdo
Copy link
Member

asmacdo commented Sep 28, 2020

@jberkhahn either way is fine with me. I didn't see the edit.

@estroz
Copy link
Member

estroz commented Sep 28, 2020

We can merge this and rebase #3955. I want a few more reviews on that one first.

@estroz estroz changed the title Add jberkhahn as reviewer OWNERS: add jberkhahn as reviewer Sep 28, 2020
@estroz estroz merged commit b661055 into operator-framework:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants