Skip to content

add unit tests for cmd/completion #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2020
Merged

add unit tests for cmd/completion #3296

merged 1 commit into from
Jul 7, 2020

Conversation

jberkhahn
Copy link
Contributor

Description of the change:
Unit tests for cmd/completion. Super simple, I couldn't really think of a good way to test the actual completion bit without a text comparison.

Motivation for the change:
See #3246

@jberkhahn
Copy link
Contributor Author

Any thoughts on this? @estroz ?

camilamacedo86
camilamacedo86 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows ok for me since it is following the same that was done for others
/LGTM
/approve.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
estroz
estroz approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camilamacedo86 camilamacedo86 merged commit 6608d2e into operator-framework:master Jul 7, 2020
@jberkhahn jberkhahn mentioned this pull request Jul 7, 2020
Closed
@jberkhahn jberkhahn mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@theishshah theishshah Awaiting requested review from theishshah

+1 more reviewer

@estroz estroz estroz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@camilamacedo86 camilamacedo86

@estroz estroz

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jberkhahn @camilamacedo86 @estroz @openshift-ci-robot