Skip to content

Fix Migration Guide link #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2020
Merged

Fix Migration Guide link #3876

merged 3 commits into from
Sep 17, 2020

Conversation

pradeepnnv
Copy link

@pradeepnnv pradeepnnv commented Sep 14, 2020 •
edited
Loading

Fixes #3862

This Change fixes the Link to project migration guide

Project Migration Guide link is broken.:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@pradeepnnv pradeepnnv changed the title Fix MIgration Guide link Fix Migration Guide link Sep 14, 2020
camilamacedo86
camilamacedo86 reviewed Sep 14, 2020
View reviewed changes
cmd/operator-sdk/main.go
"https://v0-19-x.sdk.operatorframework.io/docs/golang/project_migration_guide/\n"
projutil.PrintDeprecationWarning(depMsg)
}
if err := cli.RunLegacy(); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows great and it is just missing the fragment.
See the changelog directory. we add the fragment and teh CHANGELOG it is gen over it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @camilamacedo86 . I added the changelog fragment. Please review.

estroz
estroz previously requested changes Sep 15, 2020
View reviewed changes
camilamacedo86
camilamacedo86 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

great work 🥇

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@pradeepnnv
Copy link
Author

Thanks @camilamacedo86 . Guessing I can merge now.

@camilamacedo86
Copy link
Contributor

Hi @pradeepnnv,

Thanks @camilamacedo86 . Guessing I can merge now.

The process defines that we need 2 LGTM before merging the changes. Open source is based on feedbacks and health discussions for we achieve the best result :-) Let's see if the reason for we do not point out to master branch is clear for @estroz as well and he agrees as well with it and/or if at least we can get here +1 OK.

@pradeepnnv
Copy link
Author

Thanks @camilamacedo86 . I'll wait for @estroz to approve before merging.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@camilamacedo86
Copy link
Contributor

I @pradeepnnv,

Shows that @estroz and @joelanford for this specific scenario prefer to point out for the latest version. I just commit the @estroz suggestion. let's see if we are able to get it merged in time to ship with the next 0.19.4 release.

@joelanford joelanford mentioned this pull request Sep 17, 2020
Merged
2 tasks
pradeepnnv and others added 3 commits September 17, 2020 10:28
@joelanford
Copy link
Member

@pradeepnnv Just FYI, I rebased your branch to the latest v0.19.x, which had some other necessary fixes. Hopefully the currently running CI will pass and we can get this into v0.19.4.

@pradeepnnv pradeepnnv requested a review from estroz September 17, 2020 14:35
@joelanford joelanford dismissed estroz’s stale review September 17, 2020 15:18

Suggestion was committed.

joelanford
joelanford approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@joelanford joelanford merged commit 03c2570 into operator-framework:v0.19.x Sep 17, 2020
@pradeepnnv pradeepnnv deleted the fix-migration-guide-link branch September 17, 2020 17:17
@jmrodri jmrodri mentioned this pull request Sep 17, 2020
Merged
@joelanford joelanford mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@estroz estroz Awaiting requested review from estroz

Assignees

@joelanford joelanford

@camilamacedo86 camilamacedo86

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pradeepnnv @camilamacedo86 @joelanford @estroz @openshift-ci-robot