Skip to content

Fix Migration Guide link #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Fix Migration Guide link #3876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
557adb3
Fix MIgration Guide link
pradeepnnv Sep 14, 2020
a9b323d
Add changelog fragment
pradeepnnv Sep 14, 2020
8cc28d8
Update cmd/operator-sdk/main.go
camilamacedo86 Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/fragments/fix-migration-guide-link.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
entries:
- description: >
Fix the migration guide link in the deprecation message of `operator-sdk`
kind: "bugfix"
breaking: false
2 changes: 1 addition & 1 deletion cmd/operator-sdk/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func main() {
"See `operator-sdk init -h` and the following doc on how to scaffold a new project:\n" +
"https://v0-19-x.sdk.operatorframework.io/docs/golang/quickstart/\n" +
"To migrate existing projects to the new layout see:\n" +
"https://sdk.operatorframework.io/docs/golang/migration/project_migration_guide/\n"
"https://sdk.operatorframework.io/docs/building-operators/golang/project_migration_guide/\n"
projutil.PrintDeprecationWarning(depMsg)
}
if err := cli.RunLegacy(); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows great and it is just missing the fragment.
See the changelog directory. we add the fragment and teh CHANGELOG it is gen over it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @camilamacedo86 . I added the changelog fragment. Please review.

Expand Down