Authinfo #46
Merged
Authinfo #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will make sure that no passwords and other credential information is visible in the process information while installing via winexe.
Make sure that authinfo is always deleted, remove tmpdir on succesfull installation.
This change will make sure that no passwords and other credential information is visible in the process information while installing via winexe.
|
Looks awesome. Two questions:
|
Renamed logfile to install.log Error messages now reference the install log when they fail.
Skips actual installation and just does a connection test.
Now the following variables can be set through environment DOMAIN DOMAIN_USER DOMAIN_PASSWORD
|
@pall-valmundsson fixed in 22ff0c3 |
Logging to /var/log/okconfig and logrotation Support for -A <authfile> Removed tempdir and use mktemp only for authfiles
|
@pall-valmundsson Sorry about the hugeness of a94b26a, it should alleviate the issues about exiting on one failed host. But it does a few things as well. I'm merging this pull request to get it available in the ok-testing repository. What I have tested in my environment deployment to:
Any testers would be highly appreciated and can then use the rpm from ok-testing or from source. |
tomas-edwardsson
added a commit
that referenced
this pull request
Aug 21, 2013
Authinfo and logging improvements, mostly to remove exposure of password in command line.
| domain=${DOMAIN} | ||
| EO | ||
| else | ||
| DOMAIN=$(grep -i ^domain ${USER_AUTHFILE} |awk -F" = " '{print $2}') |
There was a problem hiding this comment.
Shouldn't the awk delimiter be "="? This one requires whitespace around =.
|
Otherwise it looks pretty good, I'm currently using a locally hacked version of an old version of install_nsclient.sh. I'll test this one soon. |
tomas-edwardsson
added a commit
that referenced
this pull request
Aug 21, 2013
authentication files can have spaces in them between key and value but I'm making the assumption that the DOMAIN never has so I remove all spaces from DOMAIN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make sure that no passwords and other credential information is visible in the process information while installing via winexe.