Skip to content

Commit 1a3744f

Browse files
committed
logging: ignore TypeErrors as well when parsing log lines, fixes:
Traceback (most recent call last): File "/usr/local/opnsense/scripts/syslog/queryLog.py", line 63, in <module> for record in log_matcher.match_records(valid_from): File "/usr/local/opnsense/scripts/syslog/log_matcher.py", line 100, in match_records if timestamp and isoparse(record['timestamp']).timestamp() < timestamp: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/dateutil/parser/isoparser.py", line 37, in func return f(self, str_in, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/dateutil/parser/isoparser.py", line 134, in isoparse components, pos = self._parse_isodate(dt_str) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/dateutil/parser/isoparser.py", line 208, in _parse_isodate return self._parse_isodate_common(dt_str) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/dateutil/parser/isoparser.py", line 213, in _parse_isodate_common len_str = len(dt_str) ^^^^^^^^^^^ TypeError: object of type 'NoneType' has no len()
1 parent 0304ab6 commit 1a3744f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/opnsense/scripts/syslog/log_matcher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def match_records(self, timestamp=None):
9999
try:
100100
if timestamp and isoparse(record['timestamp']).timestamp() < timestamp:
101101
return
102-
except ValueError:
102+
except (ValueError, TypeError):
103103
pass
104104

105105
def parse_line(self, line, format_container):

0 commit comments

Comments
 (0)