Skip to content

deprecate live variable APIs #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2017
Merged

deprecate live variable APIs #113

merged 1 commit into from
Jun 17, 2017

Conversation

wangjoshuah
Copy link
Contributor

@optimizely/fullstack-devs

mikeproeng37
mikeproeng37 approved these changes Jun 17, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. We should later link to the newer variable APIs from these deprecated APIs.

@wangjoshuah wangjoshuah merged commit 146d6c3 into master Jun 17, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/deprecate_live_variable_APIs branch June 17, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vraja2 vraja2 Awaiting requested review from vraja2

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangjoshuah @mikeproeng37