Skip to content

deprecate live variable APIs #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2017
Merged

deprecate live variable APIs #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core-api/src/main/java/com/optimizely/ab/Optimizely.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,13 +285,15 @@ public void track(@Nonnull String eventName,

//======== live variable getters ========//

@Deprecated
public @Nullable
String getVariableString(@Nonnull String variableKey,
@Nonnull String userId,
boolean activateExperiment) throws UnknownLiveVariableException {
return getVariableString(variableKey, userId, Collections.<String, String>emptyMap(), activateExperiment);
}

@Deprecated
public @Nullable
String getVariableString(@Nonnull String variableKey,
@Nonnull String userId,
Expand Down Expand Up @@ -332,13 +334,15 @@ String getVariableString(@Nonnull String variableKey,
return variable.getDefaultValue();
}

@Deprecated
public @Nullable
Boolean getVariableBoolean(@Nonnull String variableKey,
@Nonnull String userId,
boolean activateExperiment) throws UnknownLiveVariableException {
return getVariableBoolean(variableKey, userId, Collections.<String, String>emptyMap(), activateExperiment);
}

@Deprecated
public @Nullable
Boolean getVariableBoolean(@Nonnull String variableKey,
@Nonnull String userId,
Expand All @@ -354,13 +358,15 @@ Boolean getVariableBoolean(@Nonnull String variableKey,
return null;
}

@Deprecated
public @Nullable
Integer getVariableInteger(@Nonnull String variableKey,
@Nonnull String userId,
boolean activateExperiment) throws UnknownLiveVariableException {
return getVariableInteger(variableKey, userId, Collections.<String, String>emptyMap(), activateExperiment);
}

@Deprecated
public @Nullable
Integer getVariableInteger(@Nonnull String variableKey,
@Nonnull String userId,
Expand All @@ -381,13 +387,15 @@ Integer getVariableInteger(@Nonnull String variableKey,
return null;
}

@Deprecated
public @Nullable
Double getVariableDouble(@Nonnull String variableKey,
@Nonnull String userId,
boolean activateExperiment) throws UnknownLiveVariableException {
return getVariableDouble(variableKey, userId, Collections.<String, String>emptyMap(), activateExperiment);
}

@Deprecated
public @Nullable
Double getVariableDouble(@Nonnull String variableKey,
@Nonnull String userId,
Expand Down Expand Up @@ -588,6 +596,7 @@ private EventType getEventTypeOrThrow(ProjectConfig projectConfig, String eventN
* @throws UnknownLiveVariableException if there are no event types in the current project config with the given
* name
*/
@Deprecated
private LiveVariable getLiveVariableOrThrow(ProjectConfig projectConfig, String variableKey)
throws UnknownLiveVariableException {

Expand Down