throw error from createUserContext in case of invalid input

[raju-opti]

Summary

Test plan

-updated tests

Issues

[coveralls]

coverage: 79.753% (+0.02%) from 79.736%
when pulling 8a62b66 on raju/context
into e3234c7 on master.

[Copilot]

Pull Request Overview

This PR updates the createUserContext function to throw errors for invalid inputs instead of returning null.

• Update the return type in shared_types.ts to indicate a non-null OptimizelyUserContext
• Modify the error handling in Optimizely.createUserContext to throw errors with specific messages
• Update tests in index.tests.js to verify that errors are thrown for invalid inputs

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
lib/shared_types.ts	Changed createUserContext return type from nullable to non-null to match new behavior
lib/optimizely/index.ts	Updated createUserContext to throw errors (INVALID_IDENTIFIER or INVALID_ATTRIBUTES)
lib/optimizely/index.tests.js	Modified tests to assert that errors are thrown instead of returning null

[Copilot]

[nitpick] Consider reviewing the separation of input validation into two distinct checks; if combining them is feasible without losing error specificity, it might simplify the flow.

Suggested change

	if (userIdentifier === undefined || !this.validateInputs({ user_id: userIdentifier })) {
	throw new Error(INVALID_IDENTIFIER);
	}
	if (!this.validateInputs({ user_id: userIdentifier }, attributes)) {
	throw new Error(INVALID_ATTRIBUTES);
	}
	if (
	userIdentifier === undefined ||
	!this.validateInputs({ user_id: userIdentifier }, attributes)
	) {
	throw new Error(
	userIdentifier === undefined || !this.validateInputs({ user_id: userIdentifier })
	? INVALID_IDENTIFIER
	: INVALID_ATTRIBUTES
	);
	}