Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): Give Node.js consumers the unbundled package #133

Merged
merged 1 commit into from Jun 29, 2018

Conversation

spencerwilson-optimizely
Copy link
Contributor

I'm not sure it's conventional to distribute pre-bundled packages.

Copy link
Contributor

@tylerbrandt tylerbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we even build the bundle if we're not gonna point at it?

@spencerwilson-optimizely
Copy link
Contributor Author

I don't think so! See #135

@spencerwilson-optimizely spencerwilson-optimizely merged commit 03f52d2 into master Jun 29, 2018
@spencerwilson-optimizely spencerwilson-optimizely deleted the sw/dont-bundle-node branch June 29, 2018 01:03
spencerwilson-optimizely added a commit that referenced this pull request Jun 29, 2018
Since #133, we're no longer distributing an already-bundled package. With that change, I don't think there are any consumers of these 'build' run-scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants