fix (isFeatureEnabled): filter empty attribute values from impression event #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
requested review from
mikeproeng37,
spencerwilson-optimizely and
aliabbasrizvi
1 similar comment
mikeproeng37
approved these changes
Sep 21, 2018
aliabbasrizvi
approved these changes
Sep 21, 2018
|
@mikeng13 @aliabbasrizvi |
|
I think @msohailhussain is right - that's the best place to fix this. |
mjc1283
deleted the
mcarroll/is-feature-enabled-filter-empty-attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this change, attribute properties with null or undefined values are filtered out of impression events that are sent as a result of a feature being enabled via a feature test. This makes isFeatureEnabled behave the same way as activate with respect to null/undefined values in attributes in impression events.
Test plan
Added new unit test