-
Notifications
You must be signed in to change notification settings - Fork 83
refactor: Removed dependency on lodash.values #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
suggested changes
Feb 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use objectValues
function already implemented in @optimizely/js-sdk-utils
package (
export function objectValues<K>(obj: { [key: string]: K }): K[] { |
mjc1283
approved these changes
Feb 19, 2020
mjc1283
approved these changes
Feb 21, 2020
f8fdfae
to
fa6343b
Compare
@mjc1283 I removed values from fns altogether. there was only one usage, i used objectValues from js-sdk-utils directly there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaced lodash values function with
objectValues
from js-sdk-utils. This is part of an effort to remove lodash dependency to reduce bundle size.Test Plan
All Unit tests and Full Stack SDK compatibility passed