Skip to content

refactor: Removed dependency on lodash.values #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 25, 2020

Conversation

zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Feb 15, 2020

Summary

Replaced lodash values function with objectValues from js-sdk-utils. This is part of an effort to remove lodash dependency to reduce bundle size.

Test Plan

All Unit tests and Full Stack SDK compatibility passed

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.559% when pulling d75a041 on zeeshan/replace_lodash_values into eb47310 on master.

@coveralls
Copy link

coveralls commented Feb 15, 2020

Coverage Status

Coverage remained the same at 97.562% when pulling e8bc418 on zeeshan/replace_lodash_values into 31b5a4d on master.

@zashraf1985 zashraf1985 changed the title Replaced lodash values function with Object.values Removed dependency on lodash.values Feb 15, 2020
@zashraf1985 zashraf1985 marked this pull request as ready for review February 15, 2020 06:48
@zashraf1985 zashraf1985 requested a review from a team as a code owner February 15, 2020 06:48
Copy link
Contributor

@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use objectValues function already implemented in @optimizely/js-sdk-utils package (

export function objectValues<K>(obj: { [key: string]: K }): K[] {
).

@zashraf1985 zashraf1985 removed their assignment Feb 19, 2020
@zashraf1985 zashraf1985 changed the title Removed dependency on lodash.values refactor: Removed dependency on lodash.values Feb 21, 2020
@zashraf1985 zashraf1985 force-pushed the zeeshan/replace_lodash_values branch from f8fdfae to fa6343b Compare February 22, 2020 02:22
@zashraf1985
Copy link
Contributor Author

@mjc1283 I removed values from fns altogether. there was only one usage, i used objectValues from js-sdk-utils directly there

@mjc1283 mjc1283 merged commit c08435e into master Feb 25, 2020
@mjc1283 mjc1283 deleted the zeeshan/replace_lodash_values branch February 25, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants