Skip to content

chore: Update dev dependencies to prevent fsevents install error message #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2020
Merged

chore: Update dev dependencies to prevent fsevents install error message #433

merged 3 commits into from
Mar 30, 2020

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Mar 30, 2020 •
edited
Loading

Summary

Optional transitive dev dependency fsevents fails to install using Node 12.16.1, and possibly other versions. fsevents is pulled in by webpack and karma.

In this PR I updated karma and webpack to the latest versions, which depend on newer versions of fsevents, for which the error doesn't occur. I also updated karma-webpack to the latest version.

Test plan

  • Ran karma tests (xbrowser, umd)
  • Inspected UMD build output with newer webpack version

Issues

#432

@mjc1283 mjc1283 added the WIP label Mar 30, 2020
@mjc1283 mjc1283 requested a review from a team as a code owner March 30, 2020 20:01
@mjc1283 mjc1283 self-assigned this Mar 30, 2020
mikeproeng37
mikeproeng37 approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 mentioned this pull request Mar 30, 2020
Closed
@mjc1283 mjc1283 removed the WIP label Mar 30, 2020
@mjc1283 mjc1283 removed their assignment Mar 30, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.222% when pulling a13a9ef on mcarroll/fix-fsevents-error into 08deb5c on master.

@mjc1283 mjc1283 merged commit 24fe5d6 into master Mar 30, 2020
@mjc1283 mjc1283 deleted the mcarroll/fix-fsevents-error branch March 30, 2020 21:26
@mjc1283 mjc1283 mentioned this pull request Apr 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37