build: Introduce TypeScript into optimizely-sdk build #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 4, 2020 17:07
… generation. These are to fix UMD build
mikeproeng37
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
lgtm, though the browser tests are failing: https://travis-ci.org/github/optimizely/javascript-sdk/jobs/699104903
|
Oops, looks like I will have to address the Karma tests in this PR. |
mikeproeng37
approved these changes
Jun 18, 2020
jamesopti
reviewed
Jun 18, 2020
| "sinon": "^2.3.1", | ||
| "ts-node": "^8.10.2", | ||
| "typescript": "^3.3.3333", |
There was a problem hiding this comment.
This looks wrong. Is this intentional?
There was a problem hiding this comment.
All the SDK packages are using this version right now - I figured we should keep them all on the same version and upgrade in sync.
There was a problem hiding this comment.
But 3.3.3333 doesnt appear to be a valid release for this package.
Oops, I was wrong. https://github.com/microsoft/TypeScript/releases/tag/v3.3.3333
Still a strange version to pick, but it is in fact valid.
Summary: Convert event_tags_validator module from JS to TS Revise user_profile_service_validator module Test plan: Existing unit tests
… to TS (#524) * Convert project_config_schema and json_schema_validator modules to TS * Address Mike's comments * Update validate function to accept empty object
Summary: Convert attributes_validator module from JS to TS. Test plan: Existing unit tests
* Convert event_tag_utils module to TS * Convert event_tag_utils module to TS * Add type guard to avoid using any * Move 'if (eventTags)' to top level functions * Move let variables to inside the functions
mjc1283
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add TypeScript into the build for optimizely-sdk. The goal is to enable future development with TS and incremental conversion of modules from JS to TS.
string_value_validatorand several other smaller modules as examples and litmus tests of the build changesTest plan