Skip to content

fix(utils): Wrap uuid.v4 to disallow passing extra arguments and prevent dependency on uuid package types #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2020
Merged

fix(utils): Wrap uuid.v4 to disallow passing extra arguments and prevent dependency on uuid package types #509

merged 2 commits into from
Jun 15, 2020

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Jun 15, 2020

Summary

Reverts part of a prior change in the utils package for two reasons:

  • uuid.v4 has different behavior when passed arguments. We have no use for this behavior, thus it is better to ensure no arguments are accidentally passed.
  • We don't want our type definitions to be dependent on 'uuid''s type definitions

Test plan

Existing tests

@mjc1283 mjc1283 requested a review from a team as a code owner June 15, 2020 19:54
@mjc1283 mjc1283 changed the title fix: Wrap uuid.v4 to disallow passing extra arguments and prevent dependency on uuid package types fix(utils): Wrap uuid.v4 to disallow passing extra arguments and prevent dependency on uuid package types Jun 15, 2020
@mjc1283 mjc1283 removed their assignment Jun 15, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.7% when pulling 555a02f on mcarroll/fix-utils-uuid-type into 0e85707 on master.

mikeproeng37
mikeproeng37 approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit 80aa455 into master Jun 15, 2020
@mjc1283 mjc1283 deleted the mcarroll/fix-utils-uuid-type branch June 15, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37