Skip to content

ci: add source clear as a separate stage; #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2020
Merged

ci: add source clear as a separate stage; #522

merged 1 commit into from
Jul 17, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Jul 13, 2020 •
edited by msohailhussain
Loading

Summary

Adds a separate stage for Source Clear, to only run on cron builds.

Testplan

Manually need to see when cron is running this stage.

Issues

OASIS-6817

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.709% when pulling 3ca8384 on oakbani/src-clr into dbe0acb on master.

@oakbani oakbani marked this pull request as ready for review July 13, 2020 11:28
@oakbani oakbani requested a review from a team as a code owner July 13, 2020 11:28
@oakbani oakbani removed their assignment Jul 13, 2020
@oakbani oakbani requested a review from mikeproeng37 July 13, 2020 11:29
mjc1283
mjc1283 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update summary with valid issue link.

@mjc1283 mjc1283 merged commit e798d47 into master Jul 17, 2020
@mjc1283 mjc1283 deleted the oakbani/src-clr branch July 17, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

1 more reviewer

@mjc1283 mjc1283 mjc1283 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🤖 8 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oakbani @coveralls @mjc1283 @optimizely-codereview-bot