Skip to content

fix(datafile accessor): Add datafile accessor method to TS definitions #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2020
Merged

fix(datafile accessor): Add datafile accessor method to TS definitions #564

merged 1 commit into from
Sep 15, 2020

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Sep 14, 2020

Summary

Add new datafile accessor method to TS type definitions

Test plan

Manually tested with npm link and local app

@mjc1283 mjc1283 requested a review from a team as a code owner September 14, 2020 20:33
@mjc1283 mjc1283 removed their assignment Sep 14, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.689% when pulling 73404b6 on mcarroll/datafile-accessor-ts into 28260a2 on master.

mikeproeng37
mikeproeng37 approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit 84dcd39 into master Sep 15, 2020
@mjc1283 mjc1283 deleted the mcarroll/datafile-accessor-ts branch September 15, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
🤖 4 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjc1283 @coveralls @mikeproeng37 @optimizely-codereview-bot