feat(flag_decisions): update decisionSnapshot in event-processor to include metadata object #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
approved these changes
Oct 16, 2020
Comment on lines
+48
to
+57
| id: string | null | ||
| } | null | ||
|
|
||
| experiment: { | ||
| id: string | ||
| id: string | null | ||
| key: string | ||
| } | null | ||
|
|
||
| variation: { | ||
| id: string | ||
| id: string | null |
There was a problem hiding this comment.
Why are these now allowed to be null?
There was a problem hiding this comment.
When decision.experiment is not defined, we assign a ruleKey/experimentKey to an empty string, in which case I assign an experimentId and layerId to null. Similarly, the variationId is now null when variation is not defined. Please see the implementation here for details. Another way would be to assign these params to an empty string instead of null. LMKWYT @mjc1283
There was a problem hiding this comment.
Sounds good, I think using null is ok.
mjc1283
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Unit tests
Issues