Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix strictNullChecks type errors #611

Merged
merged 1 commit into from
Nov 4, 2020
Merged

fix: Fix strictNullChecks type errors #611

merged 1 commit into from
Nov 4, 2020

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented Nov 4, 2020 •
edited
Loading

Summary

  • Fix strictNullChecks type errors in optimizely-sdk package.

Test plan

FSC and unit tests

Issues

SDK-issue 608

@yavorona yavorona requested a review from mjc1283 November 4, 2020 21:48
@yavorona yavorona requested a review from a team as a code owner November 4, 2020 21:48
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.707% when pulling b5fe3e7 on pnguen/fix-strictNullChecks-type-errors into 1997ca4 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.707% when pulling b5fe3e7 on pnguen/fix-strictNullChecks-type-errors into 1997ca4 on master.

@yavorona yavorona removed their assignment Nov 4, 2020
@yavorona yavorona merged commit d87f45f into master Nov 4, 2020
@yavorona yavorona deleted the pnguen/fix-strictNullChecks-type-errors branch November 4, 2020 22:12
@yavorona yavorona mentioned this pull request Nov 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yavorona @coveralls @mjc1283