Skip to content

feat: Upgrade typescript-eslint dependencies to support TS 4.0.3 #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2021
Merged

feat: Upgrade typescript-eslint dependencies to support TS 4.0.3 #676

merged 3 commits into from
Jun 1, 2021

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented Jun 1, 2021 •
edited
Loading

Summary

  • Fix recent typescript upgrade to v4.0.3 in datafile manager
  • Upgrade @typescript-eslint/eslint-plugin and @typescript-eslint/parser to 3.3.0 to support TS 4.0.3
  • Update package.json scripts to run eslint check after running tests

Test plan

Existing unit tests

@yavorona yavorona requested a review from a team as a code owner June 1, 2021 17:13
@coveralls
Copy link

coveralls commented Jun 1, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 96.999% when pulling bfc0769 on pnguen/fix-lint-dm into 64d77e5 on master.

@yavorona yavorona merged commit 10d0bfa into master Jun 1, 2021
@yavorona yavorona deleted the pnguen/fix-lint-dm branch June 1, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@yavorona yavorona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yavorona @coveralls @zashraf1985