Skip to content

fix(ForcedDecision): remove config-ready check from forced-decision apis #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

fix(ForcedDecision): remove config-ready check from forced-decision apis #727

merged 1 commit into from
Dec 8, 2021

Conversation

yasirfolio3
Copy link
Contributor

Summary

  • Remove config-ready check from forced-decision apis

Test plan

  • Unit and FSC tests

@yasirfolio3 yasirfolio3 requested a review from a team as a code owner December 3, 2021 09:37
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.16% when pulling 25958ad on yasir/remove-config-check into 9e5e51c on master.

zashraf1985
zashraf1985 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jaeopt
jaeopt approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msohailhussain msohailhussain merged commit a64f808 into master Dec 8, 2021
@msohailhussain msohailhussain deleted the yasir/remove-config-check branch December 8, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

+1 more reviewer

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@yasirfolio3 yasirfolio3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yasirfolio3 @coveralls @zashraf1985 @jaeopt @msohailhussain